fix: append seconds in Vue Vanilla time#2455
Merged
Merged
Conversation
Appends seconds if necessary in Vue Vanilla time renderer. This makes sure that we do not produce validation errors. Also allows to configure the "step" attribute via UI Schema options. Adds test cases.
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Closed
lucas-koehler
approved these changes
Jun 13, 2025
lucas-koehler
left a comment
lucas-koehler
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the fix :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appends seconds if necessary in Vue Vanilla time renderer. This makes sure that we do not produce validation errors.
Also allows to configure the "step" attribute via UI Schema options.
Adds test cases.