Skip to content

fix: array layout renderer error count fix#2477

Merged
sdirix merged 2 commits into
eclipsesource:masterfrom
martin-trajanovski:master
Aug 13, 2025
Merged

fix: array layout renderer error count fix#2477
sdirix merged 2 commits into
eclipsesource:masterfrom
martin-trajanovski:master

Conversation

@martin-trajanovski

@martin-trajanovski martin-trajanovski commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Fix for issue #2473

@netlify

netlify Bot commented Aug 12, 2025

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 1856c34
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/689c85b2c6ce3c0008c35ba1
😎 Deploy Preview https://deploy-preview-2477--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@CLAassistant

CLAassistant commented Aug 12, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@martin-trajanovski
martin-trajanovski marked this pull request as ready for review August 12, 2025 14:19

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The fix works 🎉, however the test has some issues. Please take a look.

Comment thread packages/angular-material/test/array-layout.spec.ts Outdated
Comment thread packages/angular-material/test/array-layout.spec.ts Outdated
Comment thread packages/angular-material/test/array-layout.spec.ts Outdated
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 82.796% (+0.09%) from 82.707%
when pulling 1856c34 on martin-trajanovski:master
into f815e1c on eclipsesource:master.

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@sdirix
sdirix merged commit 0a72bfe into eclipsesource:master Aug 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular material array renderer is showing wrong number of errors in the badge on top of the icon

4 participants