Skip to content

feat: add separateReadonlyFromDisabled config option#2532

Merged
lucas-koehler merged 10 commits into
eclipsesource:masterfrom
kchobantonov:separate-readonly-from-disabled
Mar 9, 2026
Merged

feat: add separateReadonlyFromDisabled config option#2532
lucas-koehler merged 10 commits into
eclipsesource:masterfrom
kchobantonov:separate-readonly-from-disabled

Conversation

@kchobantonov

Copy link
Copy Markdown
Contributor

Allows independent control of readonly and enabled states. Adds READONLY/WRITABLE rule effects. Backward compatible (default: false).

fixes #2479

Allows independent control of readonly and enabled states.
Adds READONLY/WRITABLE rule effects. Backward compatible (default: false).
@netlify

netlify Bot commented Jan 15, 2026

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 9c5c54d
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/69a99f5bb6882100089e51d0
😎 Deploy Preview https://deploy-preview-2532--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kchobantonov

kchobantonov commented Jan 16, 2026

Copy link
Copy Markdown
Contributor Author

@sdirix @lucas-koehler please review - this provides the core and vue-vuetify implementation - the other renderers can be done separately

@lucas-koehler
lucas-koehler self-requested a review January 30, 2026 15:54
@coveralls

coveralls commented Jan 30, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 82.852% (+0.1%) from 82.744%
when pulling 9c5c54d on kchobantonov:separate-readonly-from-disabled
into 754d9dd on eclipsesource:master.

@lucas-koehler lucas-koehler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kchobantonov , thanks for this contribution ❤️
The changes already look pretty good to me.

I have two points:

  1. The calculation !control.enabled || control.readonly is used in many renderers now. Could it make sense to extract a utility for this?
  2. We should add unit tests for the following:
    1. evalReadonly() function
    2. hasReadonlyRule() function
    3. isReadonly() function
    4. isInherentlyReadonly() function
    5. The new separateReadonlyFromDisabled config option behavior in isInherentlyEnabled()
    6. The new READONLY and WRITABLE rule effects

@kchobantonov

Copy link
Copy Markdown
Contributor Author

@lucas-koehler please review

sdirix
sdirix previously requested changes Mar 5, 2026

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rework. Two minor comments.

Comment thread packages/vue-vuetify/src/additional/ListWithDetailRenderer.vue Outdated
Comment thread packages/vue-vuetify/src/complex/OneOfRenderer.vue Outdated
@kchobantonov

Copy link
Copy Markdown
Contributor Author

@sdirix @lucas-koehler please review again - thanks

@kchobantonov
kchobantonov requested a review from sdirix March 5, 2026 14:04

@lucas-koehler lucas-koehler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kchobantonov LGTM now 🚀 Thanks for the contribution and all the updates ❤️

@lucas-koehler
lucas-koehler dismissed sdirix’s stale review March 9, 2026 16:50

The two comments have been fixed in the latest commit :)

@lucas-koehler
lucas-koehler merged commit fd7979a into eclipsesource:master Mar 9, 2026
8 checks passed
@lucas-koehler lucas-koehler added this to the 3.8 milestone Mar 9, 2026
@lucas-koehler

Copy link
Copy Markdown
Contributor

@sdirix I added this to the milestone despite having an issue because the issue does not consider the vuetify implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow custom renderers to handle the readonly behaviour.

4 participants