Skip to content

fix: Remove usage of lodash/isArray and React.StatelessComponent#2539

Merged
lucas-koehler merged 2 commits into
masterfrom
issues/2538-ts-errors
Mar 5, 2026
Merged

fix: Remove usage of lodash/isArray and React.StatelessComponent#2539
lucas-koehler merged 2 commits into
masterfrom
issues/2538-ts-errors

Conversation

@lucas-koehler

Copy link
Copy Markdown
Contributor

fix #2538

@netlify

netlify Bot commented Jan 22, 2026

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 5fcd38a
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/698dfd710d45ca000976cc05
😎 Deploy Preview https://deploy-preview-2539--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coveralls

coveralls commented Jan 22, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 82.781% (-0.02%) from 82.798%
when pulling 5fcd38a on issues/2538-ts-errors
into e3d804d on master.

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

The packages/vanilla-renderers/src/cells/BooleanCell.tsx also uses the StatelessComponent. Should be fixed too.

The StatelessRenderer which is now deprecated is still used in tests, i.e. packages/react/test/renderers/JsonForms.test.tsx and packages/material-renderers/test/renderers/MaterialArrayControl.test.tsx. Should we remove the usage there?

@lucas-koehler

Copy link
Copy Markdown
Contributor Author

@sdirix Thanks for the valuable feedback ❤️ . That makes total sense. I did both and integrated it in the previous commit so we can keep both commits in this PR separately on merge.

@lucas-koehler
lucas-koehler requested a review from sdirix February 12, 2026 16:20

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-koehler
lucas-koehler merged commit b85562f into master Mar 5, 2026
11 checks passed
@lucas-koehler
lucas-koehler deleted the issues/2538-ts-errors branch March 5, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TS Errors

3 participants