Drop pull_request trigger from version_command workflow#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
pull_requesttrigger from theversion_commandworkflow.Why
The job runs
composer require symplify/easy-coding-standardfrom Packagist, then assertsecs --versionprints thePHP-CS-Fixerline — a smoke test of the published scoped+downgraded artifact (guards #8).On
pull_requestit installs the currently-published package, not the PR code — so the result is identical regardless of the diff. It never tests the change, yet the fresh, uncachedcomposer requiremakes it one of the slowest jobs on every PR.The
push(main + tags) and weeklyscheduletriggers already cover the published artifact, which is the only thing this test can actually catch drift in.Change
on: - pull_request: push: branches: - main tags: - '*' schedule: - cron: '0 6 * * 1'