Match Symfony attributes by short name in StandaloneLineSymfonyAttributeParamFixer#60
Merged
Merged
Conversation
…uteParamFixer Simplify attribute detection to match short names (AsCommand, Route, …) instead of resolving full class names via use statements. Drops the NamespaceUsesAnalyzer dependency and full-name resolution logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The fixer previously resolved each attribute's full class name via
usestatements (NamespaceUsesAnalyzer) before matching against a fully-qualified allowlist. That machinery is unnecessary — attribute short names (AsCommand,Route,Autowire, …) are already distinctive enough to match on directly.What
T_STRINGright before the attribute's(.T_STRING.NamespaceUsesAnalyzerdependency plusresolveShortNameToFullName()andresolveAttributeName().Net: 31 insertions, 73 deletions.
Detection, before → after
Same result whether the attribute is imported (
#[AsCommand(...)]) or fully qualified (#[\Symfony\...\AsCommand(...)]).Tests
Added
RouteandAutowirefixtures, each in imported and FQN variants, covering method-level and constructor-param-level attributes.