variable: promote variables out of sandbox into a top-level command - #85
Merged
Conversation
Variables are an account-wide store, not a property of a sandbox, and `sandbox` held nothing else, so the extra level was pure typing. Matches the dashboard, where variables is now its own page rather than a tab under Sandboxes. No redirect from the old path: variables are pre-customer.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent sandbox variable ...becomesagent variable .... Thesandboxparent command is gone; it held nothing else.variables,var,env, plusls/rmon the leaves.variablereplacessandboxin the Platform group ofTOP_LEVEL_GROUPS, so it does not fall through to "Other".ellipsisskill updated to the new spelling.src/commands/sandbox.tsand its test renamed tovariable.ts. No logic changes.Variables are an account-wide store, not a property of a sandbox, so the extra level was pure typing. This matches the dashboard, where variables is now its own page rather than a tab under Sandboxes.
No redirect from the old path, matching the frontend call: variables are pre-customer.
The three REST routes are untouched (
GETandPUTon/v1/sandboxes/variables,DELETE /v1/sandboxes/variables/{name}). The CLI now saysvariablewhile the API still sayssandboxes/variables. Worth a follow-up in the mono repo if we want them to agree.Test plan
npm run typechecknpm test(375 pass)agent --helpshowsvariableunder Platformagent variable listreturns the real tableagent variables ls,agent var set--helpstill prints the API route linessession start --connectshorthand. Soagent sandbox ...now starts a session instead of erroring.