connect: panel the live and notice lines, mark one row per block, log /stop in the chat - #88
Merged
Merged
Conversation
… log /stop in the chat
The live activity line ("Working…", "Generating…") and ✦ notices sat bare on
the canvas while every message around them was a lifted, padded block, so a
turn in flight read as less substantial than the conversation it belonged to.
Both take a panel now.
The ▶ selection marker replaced the gutter glyph on every row of the
highlighted block, so a message with nested tool activity showed it twice (on
the ● call and on its ⎿ result) and read as two selections. It lands on the
block's first glyph row only.
/stop reported through the notice bar above the composer, which is for
transient status and scrolls away leaving nothing to show you asked. It now
appends a ✦ line to the transcript, where the rest of the conversation's
events live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes to the chat surface in
agent connect.The live activity line takes a panel.
Working…/Generating…/Running Bash(…)…sat bare on the canvas while every message around them was a lifted, padded block, so a turn in flight read as less substantial than the conversation it belonged to.activityRowsnow always setspanel: true.The
▶selection marker lands on one row per block. It replaced the gutter glyph on every row of the highlighted block, so a message with nested tool activity showed it twice — once on the●call, once on its⎿result — and read as two separate selections.markerRowIdpicks the block's first row with a glyph; the whole block still tints./stoplogs to the transcript. It reported through the notice bar above the composer, which is for transient status and scrolls away leaving nothing to show you asked. It now appends a✦line: "Stopped the agent (stopping). The conversation is saved. Send a message to pick it back up."✦notices in general (Session asleep,Session cancelled) get a panel too, so a conversation event is as legible as a message.Test plan
npm test— 381 tests passnpm run typecheckclean▶appears on exactly one row of a message with a nestedWebFetchcall plus result, the/stopnote renders as a padded✦block/stopshould show the note in the chat with the notice bar empty.