install: open the dashboard sign-in page from the CLI - #90
Merged
Conversation
Onboarding starts on the web, since the GitHub App install lives there. Give callers one command that gets them to the right page instead of a URL they have to be told. The link is built from the active host's app base, so a beta or self-hosted CLI does not send its user to prod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent install, which prints and opens<app-base>/login, the dashboard sign-in page where a new customer installs the GitHub App.appLoginUrlbuilder insrc/lib/urls.ts, resolved off the active host's app base, so a beta or self-hosted CLI does not send its user to prod.--no-browserprints the URL only, matchingagent login.agent --help; README and theellipsisskill onboarding steps mention it.Test plan
npm run typechecknpm test(386 passed, including newappLoginUrlcases)agent install --no-browserprintshttps://app.ellipsis.dev/loginELLIPSIS_APP_BASE=https://beta-app.ellipsis.dev agent install --no-browserprints the beta URLagent --helpshowsinstallunder Account;agent install --helpreads correctly