review: add 'agent review default' to set the default code review pipeline - #92
Merged
Conversation
…eline A two-rung ladder (account default + per-repo defaults, repo wins) mirroring 'agent config default', over the new GET/PUT/DELETE /v1/reviews/defaults endpoints (ellipsis-dev/ellipsis#6032). Only explicit reviews read it; webhook reviews keep matching the pipelines' own pull_requests filters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to ellipsis-dev/ellipsis#6032 (the backend half — merge that first). Requested by @hbrooks (Slack): a way to programmatically set the default code review config.
What
agent review default— which code review pipeline runs when an explicit review (agent review …/POST /v1/reviews) names none. A two-rung ladder mirroringagent config default, with the same--reposemantics (absent → account rung; bare--repo→ the repo you're standing in;--repo owner/name→ that repo):Only explicit reviews read the ladder — webhook reviews keep matching the pipelines' own
pull_requests:filters.src/commands/review.ts— thedefaultgroup (bare show / list / set / clear).src/lib/api.ts+src/lib/types.ts—listReviewDefaults/putReviewDefault/deleteReviewDefaultoverGET/PUT/DELETE /v1/reviews/defaults, hand-rolled types like the/v1/defaultstrio (neither is in the SDK's OpenAPI allowlist).src/commands/config.ts— exportsresolveRepoFlagso both ladders share the--reposemantics.Testing
ApiClient review defaultsblock intest/api.test.ts(paths, methods, envelope unwrap, therepositoryquery param encoding).npm run typecheckclean;npm test389 passed.agent review default --help/agent review --helprendering via tsx.🤖 Generated with Claude Code