Python needs to be present before llvm-git-master#441
Closed
juj wants to merge 1 commit into
Closed
Conversation
…ECUTABLE= is passed properly.
sbc100
approved these changes
Feb 24, 2020
Collaborator
Author
|
Hmm, there is an odd error I wonder if this PR caused that? That looks unrelated from my impression? |
Collaborator
|
That does looks strange.. I think @kripken wrote that code for shipping the pre-built libraries. The assertion seems to contradict the message... |
Member
|
It does look unrelated. Perhaps the current tot build was broken (libc not included for some reason) and re-running all tests fixes it? @sbc100 by contradict do you mean the error message seems confusing? |
Member
|
(I verified on the last tot build locally, and libc is there.) |
Collaborator
|
Works for me too. Maybe try re-running the tests? |
Collaborator
|
Oh wait its the test that needs updating. |
Collaborator
|
Fixed in #444 |
juj
added a commit
that referenced
this pull request
Mar 11, 2021
Collaborator
Author
|
Closing, this has gone stale. |
juj
added a commit
that referenced
this pull request
Mar 12, 2021
* Fix support for Apple M1. Node.js will still run via Rosetta 2 emulation since they do not yet have M1 support, but Python, LLVM, Emscripten and Binaryen will be native. * Update M1 python version and URL * Remove .gitignore additions * Move python first in the manifest (#441) * Use macosx-version-min when building python * Update Intel macOS python package name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python needs to be present before llvm-git-master so that -DPYTHON_EXECUTABLE= is passed properly when building llvm-git-master.