Fail closed when health and identity checks match no clients - #224
Open
damilolaedwards wants to merge 1 commit into
Open
Fail closed when health and identity checks match no clients#224damilolaedwards wants to merge 1 commit into
damilolaedwards wants to merge 1 commit into
Conversation
check_clients_are_healthy and check_consensus_identity both derive a required pass count from minClientCount, falling back to the total number of matched clients when it is left unset. With zero matched clients that fallback collapses to zero, and zero passing clients out of a zero requirement reads as a pass. A typo in clientPattern or an EL-only pool (identity checks skip clients with no consensus client before counting them) both report every client healthy or identity- verified having checked none of them. check_clients_are_healthy hits this by default, since minClientCount has no default value. check_consensus_identity defaults minClientCount to 1, so it only reaches the same bug once a playbook explicitly overrides that with minClientCount: 0. Require at least one matched client before a pass is possible in both tasks. An empty match now falls through to the same not-yet-passing path a genuinely failing client already takes: keep polling, or fail outright if failOnCheckMiss is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_clients_are_healthy and check_consensus_identity both derive a required pass count from minClientCount, falling back to the total number of matched clients when it is left unset. With zero matched clients that fallback collapses to zero, and zero passing clients out of a zero requirement reads as a pass. A typo in clientPattern or an EL-only pool (identity checks skip clients with no consensus client before counting them) both report every client healthy or identity-verified having checked none of them.
check_clients_are_healthy hits this by default, since minClientCount has no default value. check_consensus_identity defaults minClientCount to 1, so it only reaches the same bug once a playbook explicitly overrides that with minClientCount: 0.
This change requires at least one matched client before a pass is possible in both tasks. An empty match now falls through to the same not-yet-passing path a genuinely failing client already takes: keep polling, or fail outright if failOnCheckMiss is set.
Test plan