Lint errors with line endings in windows

[RodrigoCarvalhoCode]

Hi everyone,

So I'm new with this project and when I try to run the lint command to solve some errors regarding #480, it shows errors about Expected linebreaks to be 'LF' but found 'CRLF'. I'm running this on windows. Should I change some configuration in the eslint for this?

[serixscorpio]

This might be a temporary measure, but perhaps try adding a .gitattributes file to prevent git from converting line breaks in .js files:

*.js text eol=lf

The above tells git not to convert LF to CRLF upon checkout. This works if your editor in Windows can handle LF instead of CRLF.

Reference: linebreak-style rule with version control system

[adamxberlin]

This has to do with your IDE. I'm guessing you're using Visual Studio Code on Windows? It uses CRLF line endings per default, but you can set it up to use LF line endings instead (which would be a better, more permanent solution).

See this issue for instructions.

Good luck, I hope this solves it for you 🙂

[matthewmorgan]

@Futuro212 if @adamxtokyo 's suggestion works for you, please comment here for the benefit of others, and we can close this issue. 🤞

[RodrigoCarvalhoCode]

I went with another approach, I changed my .gitattributes file to keep with the LF line endings, using the git global config.

[adamxberlin]

@Futuro212 that works too, but it also means your local files will keep their CRLF line breaks and a conversion only happens on checkout. Might not make a big difference depending on your workflow, but I'd say changing your IDE settings is better since it will streamline the whole process (i.e. no needless conversion).

Either way, happy to hear you solved the issue 🙂

EDIT:
I just fixed a mistake on my part so nobody gets confused! (details)

[RodrigoCarvalhoCode]

That makes sense but solved the CRLF breaks on checkout, because I kept changing options in vscode to LF but the files still came with CRLF (without the git global config I mean).

Thanks for the help :) @adamxtokyo

[adamxberlin]

No worries @Futuro212 ! 😌

Your reply actually made me realise I made a mistake in my previous comment;
Like you said, line breaks are converted on checkout, not on push like I said 🤦‍♂️ 😅

Here's a good explanation of the different options

[SleeplessByte]

A better solution would be to change the eslint settings in the JavaScript package.jsons (or move to a config file)

linebreak-style needs to be turned off.

[adamxberlin]

Can you elaborate why that would be a better solution?

[SleeplessByte]

Changing git attributes in order to match some arbitrary rule that has nothing to do with JavaScript or modern text editors as they all handle foreign line endings correctly is imo not a good solution. As you can see here https://eslint.org/docs/rules/linebreak-style the rule is just a contingency just in case something misbehaves and it even points out that git and text editors do NOT need this. Turning off the rule that doesn't really help anyone to begin with and actually gives windows users something they don't understand (imo is just a continuation of demonizing windows users), whichbis cryptic at best ánd not part of the instructions how to get started with JavaScript, is the right approach. TL;DR because the student is the only one working with this and only the one committing or no one committing at all, this rule only adds noise.

…

On Thu, 29 Nov 2018, 22:33 Adam Grawender, ***@***.***> wrote: Can you elaborate why that would be a better solution? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#502 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB35WNj85EfQk7y4JiOj1nmteDDcI2qpks5u0FK3gaJpZM4XbEk5> .