Two Bucket: fix errant tests#905
Merged
Merged
Conversation
slaymance
changed the title
SleeplessByte
requested changes
Dec 28, 2020
SleeplessByte
left a comment
SleeplessByte
left a comment
Member
There was a problem hiding this comment.
Can you revert the test.skip changes? They are there on purpose to keep the ci passing!
SleeplessByte
approved these changes
Dec 28, 2020
Member
|
Thanks for this @slaymance . Small oversight on my part 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses part of the problem tracked in Issue #901. A couple of test cases were added that were expected to throw yet were invoked immediately in the spec file. This PR wraps those invocations in an anonymous function.
The example solution provided does not pass the test cases as it stands and will need to be addressed in a separate PR. This is an immediate fix so the tests are working for students.