fix(theme-classic) extract HomeBreadcrumbItem + fix swizzle bugs - #8445
Merged
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Contributor
Author
|
Is |
3v0k4
marked this pull request as ready for review
December 15, 2022 15:50
slorber
requested changes
Dec 16, 2022
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Contributor
Author
✅
TIL 🙏 |
3v0k4
requested review from
slorber
and removed request for
Josh-Cena and
lex111
December 16, 2022 19:12
Collaborator
|
hmmm, little CI failure that I will have to check, not your fault :) |
slorber
added a commit
that referenced
this pull request
Jan 26, 2023
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com> Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pre-flight checklist
Motivation
See #6953 (comment)
Test Plan
1.
yarn test(in the repo root) is green2.
I changed
website/package.json:and then
Notice that swizzling produces the following warning:
I also changed the icon in the .tsx
and .css
which resulted in
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
See Motivation above.