fix: make doctor command findings actionable - #432
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@farming-labs/astro
@farming-labs/astro-theme
@farming-labs/docs
@farming-labs/theme
@farming-labs/next
@farming-labs/nuxt
@farming-labs/nuxt-theme
@farming-labs/svelte
@farming-labs/svelte-theme
@farming-labs/tanstack-start
commit: |
Kinfe123
marked this pull request as ready for review
August 3, 2026 12:08
![greptile-apps[bot]](https://cdn.github.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
![cubic-dev-ai[bot]](https://cdn.github.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs doctor --ciGitHub annotations with file, line, command, reason, and proposed correction while keeping JSON stdout parseabledocs skills scaffoldcommand so the website no longer reports three false positivesRoot cause
The usefulness analyzer already retained most command failure context, but doctor reduced it to aggregate counts. Contract commands also lacked source positions, fenced commands used the opening-fence line, and the static docs CLI registry had not been updated for
skills scaffold.Validation
pnpm --filter @farming-labs/docs test— 1,334 tests passedpnpm typecheckpnpm format:checkpnpm lint— passes with existing unrelated warningsSummary by cubic
Make doctor command-health findings actionable with exact file/line locations and proposed corrections across text, JSON, and GitHub Actions annotations. Adds
--ciand--json-outputto keep annotations and JSON output separate without mixing streams.New Features
command-healthcheck in text and JSON (file, line, command, reason, proposedCorrection).\continuations and console prompts; ignore human-only blocks without shifting line numbers.docs doctor --cito emit GitHub workflow annotations on stdout, and--json-output <path>to write the JSON report; disallow--ciwith--jsonto avoid stdout collisions.Bug Fixes
docs skills scaffoldas a valid CLI subcommand to stop false positives.Written for commit 3f74171. Summary will update on new commits.