Fix tests and add header detection test for fedify/next - #977
Fix tests and add header detection test for fedify/next#977Bananamilk452 wants to merge 3 commits into
Conversation
✅ Deploy Preview for fedify-json-schema canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR adds ChangesNext.js package integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/next/src/index.test.ts`:
- Line 1: Update the test harness import in the package’s test file to use the
built-in test symbol from node:test instead of `@fedify/fixture`, leaving the
request-detection tests unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0a2cb1df-fdf1-4c40-8eda-55a326521d39
⛔ Files ignored due to path filters (1)
deno.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
deno.jsonpackages/next/deno.jsonpackages/next/src/index.test.tspackages/next/src/index.ts
| @@ -0,0 +1,24 @@ | |||
| import { test } from "@fedify/fixture"; | |||
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Use node:test as the test harness.
Line 1 imports test from @fedify/fixture, although this file tests pure request-detection logic and uses no fixture utility. Import test from node:test instead.
Based on learnings, new-package tests in this repository use Node’s built-in node:test harness.
Proposed fix
-import { test } from "`@fedify/fixture`";
+import { test } from "node:test";📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| import { test } from "@fedify/fixture"; | |
| import { test } from "node:test"; |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/next/src/index.test.ts` at line 1, Update the test harness import in
the package’s test file to use the built-in test symbol from node:test instead
of `@fedify/fixture`, leaving the request-detection tests unchanged.
Source: Learnings
- add next as dependency - add deno.json
a12b58e to
ede1cc4
Compare
Description
check-eachandtest-eachis not working in fedify/nextGithub Copilot helped me making title of this PR, gpt-5.6-terra helped checking code quality.