Skip to content

fix: verify publish manifests before release - #281

Open
okjodom wants to merge 1 commit into
fedimint:mainfrom
okjodom:fix/verify-publish-manifests
Open

fix: verify publish manifests before release#281
okjodom wants to merge 1 commit into
fedimint:mainfrom
okjodom:fix/verify-publish-manifests

Conversation

@okjodom

@okjodom okjodom commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a release-time verifier for publishable package manifests under packages/
  • fail stable, canary, and snapshot publishes if any publishable package still has workspace protocol references in dependencies, optionalDependencies, or peerDependencies
  • enforce the existing expectation that Changesets versioning must rewrite internal package references before npm publish

Why

The repo keeps workspace:* references in source manifests, and other published packages already rely on the release flow to rewrite those to concrete semver. This PR makes that assumption explicit and prevents broken publishes from reaching npm.

Validation

  • ran the verifier directly against the current source tree to confirm it fails before Changesets rewriting
  • wired the verifier into stable, canary, and snapshot release workflows before pnpm changeset publish
  • kept source package manifests unchanged

@changeset-bot

changeset-bot Bot commented Apr 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 455c464

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@okjodom
okjodom force-pushed the fix/verify-publish-manifests branch from a42f2d3 to 455c464 Compare April 21, 2026 19:48
@okjodom
okjodom requested a review from alexlwn123 April 21, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant