Skip to content

chore: update packageManager to pnpm@11.12.0 - #308

Open
Yunusabdul38 wants to merge 3 commits into
fedimint:mainfrom
Yunusabdul38:package-migration
Open

chore: update packageManager to pnpm@11.12.0#308
Yunusabdul38 wants to merge 3 commits into
fedimint:mainfrom
Yunusabdul38:package-migration

Conversation

@Yunusabdul38

@Yunusabdul38 Yunusabdul38 commented Jul 13, 2026

Copy link
Copy Markdown

Migrates the workspace from pnpm v9 to pnpm v11.

  • Updated packageManager to pnpm@11.12.0 across the project.
  • Moved overrides and configured allowBuilds in pnpm-workspace.yaml to comply with pnpm v11 workspace rules.
  • Upgraded Node.js to version 22 in the CI install-deps action (pnpm v11 requires Node.js >=22.13 for node:sqlite).

Validation: Clean install, lint, typecheck, and build all pass successfully.

Fix: #292

@changeset-bot

changeset-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a251575

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MrImmortal09

Copy link
Copy Markdown
Member

@fedimint-bot review

@elsirion
elsirion requested review from fedimint-bot and removed request for fedimint-bot July 15, 2026 20:33

@fedimint-bot fedimint-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrImmortal09

Copy link
Copy Markdown
Member

@fedimint-bot why is the iOS test failing?

@fedimint-bot

Copy link
Copy Markdown
Collaborator

iOS failure analysis

The failing check is React Native Verify / Build iOS, not the JS checks. The primary failure happens inside nix develop --accept-flake-config -c just build-ios while prebuilding the iOS UniFFI Rust library for aarch64-apple-ios:

  • Nix fails building fedimint-client-uniffi-aarch64-apple-ios-...-deps.
  • The failing dependency is the proc-macro2 build script.
  • The linker reports missing arm64 symbols such as _unlinkat, _waitpid, and _writev, then ends with ld: symbol(s) not found for architecture arm64 / clang: error: linker command failed.

The later TypeScript error:

Cannot find module './generated/fedimint_client_uniffi'

is fallout from that earlier Rust/Nix iOS build failure: the generated UniFFI bindings never get produced, so @fedimint/react-native-bindings cannot build declarations.

This does not look specific to the pnpm 11 change in this PR. I checked a newer React Native Verify run from another PR and it fails in the same iOS Nix step with the same proc-macro2 / arm64 linker error while still using pnpm 9.15.9. Android passes in both runs.

One extra note: the iOS workflow does not use the changed .github/actions/install-deps action. It enters the Nix iOS shell directly, and that shell currently provides Node v24.11.1, which explains the Unsupported engine: wanted {"node":"22.x"} warnings. Those warnings are worth cleaning up separately, but they are not the terminal failure here.

@Ayush4958

Copy link
Copy Markdown
Contributor

@MrImmortal09 ,
I think this PR needs re-run for CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate pnpm from v9 to v11

4 participants