feat(s3perm): grant blob.Abort with the write command set - #36
Closed
frrist wants to merge 1 commit into
Closed
Conversation
A key that may park bytes on a provider (multipart UploadPart) must be able to abort its own parked upload: /blob/abort is the abort leg of ingot's deferred-accept multipart lifecycle, and the proof store ingot captures at UploadPart is the authority for its off-request cleanup (the session-expiry sweeper, DeleteBucket's implicit abort of in-flight uploads). Without the grant those invocations go out proofless and sprue rejects them, so parked part blobs leak on abort. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
closing in favor of #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
blob.AborttocmdsAdd: a key that may park bytes on a provider (multipartUploadPart) must be able to abort its own parked upload./blob/abortis the abort leg of ingot's deferred-accept multipart lifecycle (fil-forge/ingot#40), and the proof store ingot captures atUploadPartis the authority for its off-request cleanup (the session-expiry sweeper,DeleteBucket's implicit abort of in-flight uploads). Without the grant those invocations go out proofless and sprue rejects them ("is not issued by subject and has no proofs"), so parked part blobs leak on abort — the failure behind ingot#40'sTestForgeDeferredMultipart/AbortRejectsgate and theCompleteMultipartUpload_conditional_writesxfail.Part of the blob-removal landing chain: fil-forge/libforge#49 (merged) → fil-forge/piri#30 → fil-forge/smelt#19 → this → fil-forge/ingot#40.
🤖 Generated with Claude Code