feat(auth): Add support for Auth Emulator - #1044
Merged
Merged
Conversation
samtstern
changed the title
yuchenshi
reviewed
Sep 29, 2020
Member
|
BTW awesome work, will take a detailed pass later once we settle the bigger picture questions |
yuchenshi
approved these changes
Oct 13, 2020
yuchenshi
left a comment
yuchenshi
left a comment
Member
There was a problem hiding this comment.
LGTM (pending verifyIdToken change)
hiranya911
suggested changes
Oct 13, 2020
hiranya911
left a comment
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
Looks mostly good. I've made some suggestions on cleaning up the implementation and improving the test coverage.
| private readonly shortNameArticle: string; | ||
|
|
||
| constructor(private clientCertUrl: string, private algorithm: string, | ||
| constructor(private clientCertUrl: string, private algorithm: jwt.Algorithm, |
Contributor
There was a problem hiding this comment.
This really ought to accept an options object. But it's ok to do that later.
samtstern
commented
Oct 14, 2020
| * @inheritDoc | ||
| */ | ||
| public getAccountId(): Promise<string> { | ||
| return Promise.resolve('firebase-auth-emulator@example.com'); |
Contributor
Author
There was a problem hiding this comment.
I'm not so sure about this ... could we do something better here?
Member
There was a problem hiding this comment.
This is probably the best thing we can do
samtstern
marked this pull request as ready for review
October 14, 2020 12:06
Contributor
Author
|
@yuchenshi and @hiranya911 thank you both for your comments, I got the code into a much cleaner state where |
yuchenshi
approved these changes
Oct 14, 2020
hiranya911
suggested changes
Oct 14, 2020
hiranya911
left a comment
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
Thanks. This looks pretty good. Just a bunch of nits and cleanup suggestions. Lets use single quotes around string literals everywhere.
hiranya911
approved these changes
Oct 15, 2020
hiranya911
left a comment
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a suggestion.
yuchenshi
approved these changes
Oct 16, 2020
hiranya911
changed the title
hiranya911
changed the title
1 task
|
❤️❤️❤️❤️❤️❤️ |
|
Thank you for implementing the emulator! Good work! |
BorntraegerMarc
pushed a commit
to BorntraegerMarc/firebase-admin-node
that referenced
this pull request
Jan 28, 2021
* Basic URL replacement and custom tokens * Fix test * Tests actually pass * Mock verifyIdToken * Add another test * Small style change * Small simplification * Significant cleanup of all the useEmulator stuff * Make sure we don't use env var to short-circuit ID Token verification * Make lint pass * Add unit tests that go through the Auth interface * Hiranya nits * Make private method even more private and scary, require env * Make the private method throw * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
For Googlers: this design doc explains the behavior changes and security implications.
verifyIdTokenTesting
API Changes
N/A
RELEASE NOTE: Added support for Firebase Auth Emulator.