[A11y] Create a11y page with placeholders.#9889
Conversation
![gemini-code-assist[bot]](https://cdn.github.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Accessibility screen to DevTools, guarded by a feature flag, which includes placeholder UI panes for diagnostics, a semantics tree, and overrides, along with its controller and corresponding tests. The review feedback highlights three main areas for improvement: removing an unused controller field in the screen body state to prevent analyzer warnings, updating the screen metadata to correctly require a connection and a Flutter app, and optimizing performance by using MediaQuery.sizeOf(context) instead of MediaQuery.of(context).size.
…e and diagnostics panels Replace custom outline border color with standard theme focusColor Replace hardcoded BorderRadius with theme defaultBorderRadius constant Add placeholder Accessibility screen and controller
66ff59c to
b3681b2
Compare
| 'accessibility', | ||
| title: 'Accessibility', | ||
| icon: Icons.accessibility, | ||
| requiresFlutter: true, |
There was a problem hiding this comment.
does this page work for flutter web apps or should it be disabled for web?
There was a problem hiding this comment.
web apps also have semantics tree and a11y settings. This page should work.
| ); | ||
|
|
||
| // Diagnostics tab should be active by default and contain placeholder text | ||
| expect(find.text('Accessibility Diagnostics'), findsOneWidget); |
There was a problem hiding this comment.
once you switch to helper widgets for these views instead of methods that return widgets, you can change the tests to find by type instead of text, and that will make the tests more robust in case any of these strings change.
hannah-hyj
added
the
autosubmit
3 participants
The screen is gated by the FeatureFlags.accessibility flag.
internal link: go/devtool-a11y-userjourney
issue: #9893
Pre-launch Checklist
General checklist
///).Issues checklist
contributions-welcomeorgood-first-issuelabel.contributions-welcomeorgood-first-issuelabel. I understand this means my PR might take longer to be reviewed.Tests checklist
AI-tooling checklist
Feature-change checklist
release-notes-not-requiredlabel or left a comment requesting the label be added.packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.If you need help, consider asking for help on Discord.