cosign: fix v3 bundle verify on http and private CA registries + pass TLS to Rekor - #2061
Merged
Conversation
stealthybox
force-pushed
the
sigstore-transport
branch
from
May 26, 2026 06:38
295b592 to
211fb0a
Compare
stefanprodan
marked this pull request as draft
May 26, 2026 10:26
stealthybox
force-pushed
the
sigstore-transport
branch
from
May 26, 2026 16:04
211fb0a to
ffa18cc
Compare
stealthybox
force-pushed
the
sigstore-transport
branch
from
June 4, 2026 05:19
ffa18cc to
b00f7ba
Compare
matheuscscp
reviewed
Jun 4, 2026
Signed-off-by: leigh capili <leigh@null.net>
WithInsecure passes name.Insecure to GetBundles/VerifyImageAttestations for v3 bundle discovery on HTTP registries. Follows the same pattern as notation's WithInsecureRegistry. WithTLSConfig passes a *tls.Config to the Rekor client, supporting private CAs from certSecretRef. Replaces the cosign CLI rekor wrapper with a direct rekor.GetRekorClient call to thread the option through. Includes a test using a fake non-loopback hostname to verify the insecure option is required for bundle discovery on HTTP registries. Signed-off-by: leigh capili <leigh@null.net>
Pass obj.Spec.Insecure and transport.TLSClientConfig to the cosign verifier so v3 bundle discovery and Rekor connections use the same transport settings as the registry. Signed-off-by: leigh capili <leigh@null.net>
…hart OCI Pass clientOpts.TLSConfig and clientOpts.Insecure to the cosign verifier in makeVerifiers so that HelmChart verification of OCI-sourced charts works against registries behind private CAs and on HTTP. Signed-off-by: leigh capili <leigh@null.net>
stealthybox
force-pushed
the
sigstore-transport
branch
from
June 4, 2026 08:00
b00f7ba to
34c7c9c
Compare
stealthybox
marked this pull request as ready for review
June 4, 2026 08:26
stefanprodan
approved these changes
Jun 4, 2026
stefanprodan
left a comment
stefanprodan
left a comment
Member
There was a problem hiding this comment.
LGTM
Thanks @stealthybox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2003.
Fixes:
(GetBundles creates internal refs without copying name.Insecure from the original ref)
Changes:
Unit test covers the insecure bundle discovery fix using a fake
non-loopback hostname.