Add --insecure-allow-http flag to block insecure HTTP sources - #2119
Open
amarkdotdev wants to merge 1 commit into
Open
Add --insecure-allow-http flag to block insecure HTTP sources#2119amarkdotdev wants to merge 1 commit into
amarkdotdev wants to merge 1 commit into
Conversation
Wire helper.ConnectionOptions into GitRepository, HelmRepository, HelmChart, Bucket, and OCIRepository reconcilers so cluster admins can disallow plain HTTP URLs, HTTP proxies, and spec.insecure when the flag is set to false. Azure/GCP buckets with insecure stall as UnsupportedConnectionType. Fixes fluxcd#806 Signed-off-by: amarkdotdev <64331623+amarkdotdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--insecure-allow-http(default true) viahelper.ConnectionOptions(RFC-004 / Create a new flag to block use of HTTP endpoints for sources #806)spec.insecurewhen the flag is false for GitRepository, HelmRepository (default), HelmChart/OCI HelmRepository, Bucket, and OCIRepositoryspec.insecureasUnsupportedConnectionTypehttp://URLs when the flag is false (managed libgit2 transport removed; go-git redirect gated by scheme reject)Test plan
--insecure-allow-http=falseand reject HTTP sources end-to-endFixes #806