Ignore run-msbuild.bat - #4875
Merged
Merged
Conversation
vitaut
requested changes
Aug 2, 2026
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR.
I think it would be better to fix the source of the problem rather than ignore the generated file. run-msbuild.bat is created by file(WRITE run-msbuild.bat ...), which writes it into the source directory. I suggest writing it to ${CMAKE_CURRENT_BINARY_DIR} instead.
Also, could you elaborate on what you mean by "breaks submodule tracking"?
Contributor
Author
When I add this as submodule, cmake generates this file and diff will show in git. diff --git a/external/formatter/fmt/fmtlib b/external/formatter/fmt/fmtlib
--- a/external/formatter/fmt/fmtlib
+++ b/external/formatter/fmt/fmtlib
@@ -1 +1 @@
-Subproject commit abb66c1f3576489ac3bdcee47c19a3fba6dddb07
+Subproject commit abb66c1f3576489ac3bdcee47c19a3fba6dddb07-dirty |
Contributor
Author
This is a better fix and does work. I updated PR with this change |
vitaut
approved these changes
Aug 3, 2026
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only for visual studio generator, when adding as subdir, this file is created and breaks submodule tracking until this file is ignored.