Fix utf-8 bug for tj3ts_receiver - #1
Merged
Merged
Conversation
When decoding an attachment the line.encoding is set to "ASCII-8BIT", even when reading an UTF-8 attachment. So, force the encoding indication and then check its compliant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When decoding an attachment the line.encoding is set to "ASCII-8BIT", even when reading an UTF-8 attachment. So, force the encoding indication and then check its compliant.
The fix is simple. An example of what happens is given in the attached email file "testrb.eml.txt" and a script which copies the relevant part of code with the force_encoding (attached .rb files were renamed to .rb.txt)
Run like so to see the bug: ruby bugutf.rb # creates a traceback
and like this to see the fix: ruby bugutf_fixed.rb # runs ok, accented characters like in "détails" are supported.
testrb.eml.txt
bugutf.rb.txt
bugutf_fixed.rb.txt
And thanks for all the good work, ,tj3 is amazing !