Skip to content

fix: replace menu icon on purchases grid with download icon - #1001

Merged
smarcet merged 1 commit into
masterfrom
fix/download-icon-purchases-grid
Jul 2, 2026
Merged

fix: replace menu icon on purchases grid with download icon#1001
smarcet merged 1 commit into
masterfrom
fix/download-icon-purchases-grid

Conversation

@tomrndom

@tomrndom tomrndom commented Jul 1, 2026

Copy link
Copy Markdown

ref: https://app.clickup.com/t/9014802374/86bahg5pj

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Style
    • Updated the action icon in sponsor purchase tables to a download symbol for a clearer, more consistent visual cue.
    • The change applies to sponsor purchase list views and related sponsor purchases tabs, with no impact on functionality or data.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR replaces the MenuIcon with DownloadIcon in the table action column of two sponsor purchase pages: the show-purchase-list page and the sponsor purchases tab. Only the icon import and rendered icon component were changed.

Changes

Icon swap in sponsor purchase tables

Layer / File(s) Summary
Show purchase list page action icon
src/pages/sponsors/show-purchase-list-page/index.js
Replaced MenuIcon import and usage with DownloadIcon in the "menu" column's action IconButton.
Sponsor purchases tab action icon
src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js
Replaced MenuIcon import and usage with DownloadIcon in the row action IconButton.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: smarcet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: swapping the purchases grid action icon from a menu icon to a download icon.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/download-icon-purchases-grid

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/pages/sponsors/show-purchase-list-page/index.js (1)

90-92: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Icon now implies download, but handler still just logs to console.

handleMenu (Line 90-92) only does console.log("MENU : ", item), and the onClick at Line 187 still wires to it. Swapping the icon to DownloadIcon without implementing an actual download action is misleading to users — clicking it produces no visible effect. Consider either wiring this to real download logic (e.g., an API call, similar to the handleDownload pattern in sponsor-media-upload-tab/index.js) or reverting the icon if the download functionality is not yet implemented.

Also applies to: 178-192

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/pages/sponsors/show-purchase-list-page/index.js` around lines 90 - 92,
The menu action in handleMenu is still only logging to the console, but the UI
now uses a DownloadIcon and onClick wiring that suggests a real download. Update
handleMenu and the related onClick hookup in show-purchase-list-page so the icon
triggers actual download behavior (preferably following the handleDownload
pattern used in sponsor-media-upload-tab/index.js), or revert the icon back to a
non-download action if download is not implemented yet.
♻️ Duplicate comments (1)
src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js (1)

83-85: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Same icon/behavior mismatch as show-purchase-list-page/index.js.

handleMenu (Line 83-85) still just logs to console and is wired to the new DownloadIcon button (Line 170). No actual download is triggered.

Also applies to: 161-175

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js` around
lines 83 - 85, The DownloadIcon action is still wired to handleMenu, but that
function only logs to the console and does not start any download. Update
handleMenu in sponsor-purchases-tab/index.js to perform the same real download
behavior used by show-purchase-list-page instead of console.log, and make sure
the DownloadIcon button calls that download flow so the icon matches the actual
action.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/pages/sponsors/show-purchase-list-page/index.js`:
- Around line 90-92: The menu action in handleMenu is still only logging to the
console, but the UI now uses a DownloadIcon and onClick wiring that suggests a
real download. Update handleMenu and the related onClick hookup in
show-purchase-list-page so the icon triggers actual download behavior
(preferably following the handleDownload pattern used in
sponsor-media-upload-tab/index.js), or revert the icon back to a non-download
action if download is not implemented yet.

---

Duplicate comments:
In `@src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js`:
- Around line 83-85: The DownloadIcon action is still wired to handleMenu, but
that function only logs to the console and does not start any download. Update
handleMenu in sponsor-purchases-tab/index.js to perform the same real download
behavior used by show-purchase-list-page instead of console.log, and make sure
the DownloadIcon button calls that download flow so the icon matches the actual
action.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4d50a0c6-1c98-489b-a597-28fdbb8177f2

📥 Commits

Reviewing files that changed from the base of the PR and between cfc6779 and 0973ba5.

📒 Files selected for processing (2)
  • src/pages/sponsors/show-purchase-list-page/index.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet
smarcet merged commit e99030a into master Jul 2, 2026
9 checks passed
smarcet pushed a commit that referenced this pull request Jul 16, 2026
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants