fix: replace menu icon on purchases grid with download icon - #1001
Conversation
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
📝 WalkthroughWalkthroughThis PR replaces the ChangesIcon swap in sponsor purchase tables
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/pages/sponsors/show-purchase-list-page/index.js (1)
90-92: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winIcon now implies download, but handler still just logs to console.
handleMenu(Line 90-92) only doesconsole.log("MENU : ", item), and theonClickat Line 187 still wires to it. Swapping the icon toDownloadIconwithout implementing an actual download action is misleading to users — clicking it produces no visible effect. Consider either wiring this to real download logic (e.g., an API call, similar to thehandleDownloadpattern insponsor-media-upload-tab/index.js) or reverting the icon if the download functionality is not yet implemented.Also applies to: 178-192
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/sponsors/show-purchase-list-page/index.js` around lines 90 - 92, The menu action in handleMenu is still only logging to the console, but the UI now uses a DownloadIcon and onClick wiring that suggests a real download. Update handleMenu and the related onClick hookup in show-purchase-list-page so the icon triggers actual download behavior (preferably following the handleDownload pattern used in sponsor-media-upload-tab/index.js), or revert the icon back to a non-download action if download is not implemented yet.
♻️ Duplicate comments (1)
src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js (1)
83-85: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winSame icon/behavior mismatch as
show-purchase-list-page/index.js.
handleMenu(Line 83-85) still just logs to console and is wired to the newDownloadIconbutton (Line 170). No actual download is triggered.Also applies to: 161-175
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js` around lines 83 - 85, The DownloadIcon action is still wired to handleMenu, but that function only logs to the console and does not start any download. Update handleMenu in sponsor-purchases-tab/index.js to perform the same real download behavior used by show-purchase-list-page instead of console.log, and make sure the DownloadIcon button calls that download flow so the icon matches the actual action.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/pages/sponsors/show-purchase-list-page/index.js`:
- Around line 90-92: The menu action in handleMenu is still only logging to the
console, but the UI now uses a DownloadIcon and onClick wiring that suggests a
real download. Update handleMenu and the related onClick hookup in
show-purchase-list-page so the icon triggers actual download behavior
(preferably following the handleDownload pattern used in
sponsor-media-upload-tab/index.js), or revert the icon back to a non-download
action if download is not implemented yet.
---
Duplicate comments:
In `@src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js`:
- Around line 83-85: The DownloadIcon action is still wired to handleMenu, but
that function only logs to the console and does not start any download. Update
handleMenu in sponsor-purchases-tab/index.js to perform the same real download
behavior used by show-purchase-list-page instead of console.log, and make sure
the DownloadIcon button calls that download flow so the icon matches the actual
action.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4d50a0c6-1c98-489b-a597-28fdbb8177f2
📒 Files selected for processing (2)
src/pages/sponsors/show-purchase-list-page/index.jssrc/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
ref: https://app.clickup.com/t/9014802374/86bahg5pj
Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com
Summary by CodeRabbit