fix: add purchase_date catch for pending orders, replace created prop… - #1011
Merged
Conversation
… use Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesPurchase status consistency
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
smarcet
reviewed
Jul 17, 2026
smarcet
reviewed
Jul 17, 2026
smarcet
reviewed
Jul 17, 2026
smarcet
requested changes
Jul 17, 2026
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
smarcet
pushed a commit
that referenced
this pull request
Jul 20, 2026
#1011) * fix: add purchase_date catch for pending orders, replace created prop use Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com> * fix: replace const values with i18n strings Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com> --------- Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/9014802374/86bay73p5
Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com
Summary by CodeRabbit
purchased_dateare labeled Pending (localized) instead of “N/A” or formatting an incorrect/placeholder value.