Skip to content

fix: adjust default values on sponsor forms items rates - #1029

Open
tomrndom wants to merge 1 commit into
masterfrom
fix/global-sponsor-form-items-rates
Open

fix: adjust default values on sponsor forms items rates#1029
tomrndom wants to merge 1 commit into
masterfrom
fix/global-sponsor-form-items-rates

Conversation

@tomrndom

@tomrndom tomrndom commented Jul 30, 2026

Copy link
Copy Markdown

ref: https://app.clickup.com/t/9014802374/86bb4x9wj

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Bug Fixes
    • Corrected default quantity fields to use numeric zero values instead of empty text.
    • Improved consistency and reliability when handling sponsor item quantities.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 463ebec3-6641-4689-ab4b-46724c70a580

📥 Commits

Reviewing files that changed from the base of the PR and between fba9ad0 and f74b3a8.

📒 Files selected for processing (2)
  • src/reducers/sponsors/__tests__/sponsor-form-items-list-reducer.test.js
  • src/reducers/sponsors/sponsor-form-items-list-reducer.js

📝 Walkthrough

Walkthrough

The sponsor form item reducer now initializes three quantity-related fields with numeric 0 values instead of empty strings, and the corresponding test default state is updated to match.

Changes

Sponsor quantity defaults

Layer / File(s) Summary
Update quantity default state
src/reducers/sponsors/sponsor-form-items-list-reducer.js, src/reducers/sponsors/__tests__/sponsor-form-items-list-reducer.test.js
The reducer and test fixture initialize quantity_limit_per_show, quantity_limit_per_sponsor, and default_quantity as numeric zero values.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: updating default values for sponsor form item fields.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/global-sponsor-form-items-rates

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant