skip checkProximityEvents on event without schedule dates allowed - #34
Merged
Merged
Conversation
Signed-off-by: romanetar <roman.gutierrez@gmail.com>
smarcet
pushed a commit
that referenced
this pull request
Jul 21, 2026
…1014) * feat(sponsor-reports): contained forms display and sponsor booth fallback Consumes two additive sponsor-reports-api fields shipped for the summit-73 ops fixes (backend PRs #33/#34 in that repo): - OrdersTable Type column renders the order's full contained form set ("CL - Cleaning, EL - Electrical") when `forms` is present. The backend form_code filter matches by containment, so showing only the first line's label made filtered rows look wrong. Falls back to the legacy form.display until the API ships, and shows the bare code for pre-backfill rows whose form name is null. - Destination in BOTH lines views (LinesManifestView and the By Item drill-down) falls back from the line's add_on_name to the new sponsor_booth (the sponsor's Booth-type add-on name(s)), using || to match the backend CSV's `or` precedence so an empty-string add-on falls through. The muted "Booth" placeholder now appears only for sponsors with no booth add-on on file. No new files; reducers pass rows through verbatim so no action/reducer/ i18n changes. Both renders degrade gracefully against the pre-deploy API shape. Tests pin the join format, || precedence (empty-string case), absent/empty forms fallback, and the By Item contributor mapping. Co-Authored-By: Claude <noreply@anthropic.com> * refactor(sponsor-reports): fold booth fallback into Destination Destination now owns the add_on || booth precedence (and its why-comment) instead of both call sites repeating the expression. Also pins the empty-string form-name case in the OrdersTable Type column. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
smarcet
pushed a commit
that referenced
this pull request
Jul 21, 2026
…1014) * feat(sponsor-reports): contained forms display and sponsor booth fallback Consumes two additive sponsor-reports-api fields shipped for the summit-73 ops fixes (backend PRs #33/#34 in that repo): - OrdersTable Type column renders the order's full contained form set ("CL - Cleaning, EL - Electrical") when `forms` is present. The backend form_code filter matches by containment, so showing only the first line's label made filtered rows look wrong. Falls back to the legacy form.display until the API ships, and shows the bare code for pre-backfill rows whose form name is null. - Destination in BOTH lines views (LinesManifestView and the By Item drill-down) falls back from the line's add_on_name to the new sponsor_booth (the sponsor's Booth-type add-on name(s)), using || to match the backend CSV's `or` precedence so an empty-string add-on falls through. The muted "Booth" placeholder now appears only for sponsors with no booth add-on on file. No new files; reducers pass rows through verbatim so no action/reducer/ i18n changes. Both renders degrade gracefully against the pre-deploy API shape. Tests pin the join format, || precedence (empty-string case), absent/empty forms fallback, and the By Item contributor mapping. Co-Authored-By: Claude <noreply@anthropic.com> * refactor(sponsor-reports): fold booth fallback into Destination Destination now owns the add_on || booth precedence (and its why-comment) instead of both call sites repeating the expression. Also pins the empty-string form-name case in the OrdersTable Type column. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://tipit.avaza.com/project/view#!tab=task-pane&groupby=MyTaskDueDate&view=vertical&task=2811979&fileview=grid
Signed-off-by: romanetar roman.gutierrez@gmail.com