feat(sponsor-reports): port Sponsor Reports FE into Summit Admin (Sponsors → Reports)

[caseylocker]

ref: https://app.clickup.com/t/86bak754x

Ports the two sponsor reports (Purchase Details + Sponsor Assets, incl. the per-sponsor asset drill-down) out of sponsor-services and into summit-admin as an admin-only "Reports" sub-item under the Sponsors menu, reading the in-context summit. Backend (sponsor-reports-api) is unchanged. This is Phase 1 — parity port; the JP-pivot logistics/finance features are Phase 2 follow-ons.

What's included

• Placement & access: Sponsors → Reports sub-item; layout wrapped Restrict(withRouter(SponsorReportsLayout), "admin-sponsors") — an explicit admin-only gate that reuses the existing admin-sponsors key and closes the direct-URL gap for the reports area. Summit is in-context (summit picker + /reports/summits dropped).
• Re-implementation on summit-admin's stack (not a copy of the source): react-redux 5 connect() (no hooks), react-router 4 withRouter (no v6 hooks), i18n-react T.translate (no react-i18next), uicore MuiTable (no @mui/x-data-grid), CSV via uicore getCSV.
• Purchase Details: OrdersTable rebuilt on MuiTable; formatCheckoutTime handles both ISO and epoch; Total Refunded tile renders only when summary.total_refunded != null (auto-appears once that field ships — no FE change needed).
• Sponsor Assets: group-by sponsor/component views + per-sponsor drill-down; hard-coded drill-down links rewired to /app/summits/:summitId/sponsors/reports/sponsor-assets/sponsors/:sponsorId.
• Landing with two report cards; breadcrumb trail Sponsors → Reports → <page>.
• Env: SPONSOR_REPORTS_API_URL injected in app.js + .env/.env.example.

Tests / quality

• yarn jest: 915 passing, 0 regressions vs master. yarn lint: 0 new errors (only the repo's pre-existing prop-types warnings).
• Reviewed per-task (opus) + whole-branch (opus) + an independent Codex pass — all clean (0 Critical / 0 Important).

Deploy note (not blocking this PR)

Backend auth wiring (D5) is done on dev — repointed the deployed sponsor-reports-api scope env to reports/all + added the admin groups; verified both reports load real data on dev. Staging/prod need the same env at launch (tracked in the ClickUp ticket). No IDP change was needed (summit-admin already carries reports/all).

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Added a new Sponsor Reports area in the app, including a landing page, Purchase Details (Orders + Line Items), Sponsor Assets, and sponsor drill-down pages.
  • Introduced filtering, grouping, pagination, status rollups, and CSV export with print-friendly reporting layout.
• Bug Fixes
  • Improved handling of loading, empty, validation, and read-error states, including clearer behavior when CSV export is disabled.
  • Added more robust display formatting for dates, currency, and rich-text content.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds sponsor reports configuration, Redux wiring, shared report UI, routes, and two sponsor report pages with supporting utilities and tests.

Changes

Sponsor reports feature

Layer / File(s)	Summary
Helpers and query shaping src/app.js, .env.example, src/utils/*, src/utils/__tests__/*, src/hooks/usePrint.js, src/hooks/__tests__/usePrint.test.js	Environment config, report error/query utilities, formatting helpers, manifest grouping, and hook support are added with tests.
Async actions src/actions/sponsor-reports-actions.js, src/actions/__tests__/sponsor-reports-actions.test.js	Sponsor report thunks fetch purchase details, purchase-detail lines, sponsor assets, and drilldown data and route read, validation, export-disabled, and reauth outcomes.
Reducers and store src/reducers/sponsors/*, src/reducers/sponsors/__tests__/*, src/store.js	New reducer slices track purchase-details, purchase-details lines, sponsor-asset, and drilldown state, and the store persists the corresponding keys.
Report controls and print support src/components/sponsors/reports/{ReportShell,FilterBar,ExportCsvButton,GroupByToggle,ReportViewToggle}.js, src/components/sponsors/reports/report-print.css, src/components/sponsors/reports/__tests__/{ReportShell,FilterBar,ExportCsvButton,GroupByToggle,ReportViewToggle}.test.js	Reusable report shell, filters, CSV export, grouping toggles, view toggle, and print stylesheet are added with tests.
Status and display primitives src/components/sponsors/reports/{statusTone,StatusPill,StatusRollupChips,SummaryPanel,TierBadge,SponsorAvatar}.js, src/components/sponsors/reports/__tests__/{StatusPill,StatusRollupChips,SummaryPanel,TierBadge,SponsorAvatar}.test.js	Status tone mapping, pills, rollup chips, summary tiles, tier badges, and sponsor avatars are added with tests.
Tables and line manifests src/components/sponsors/reports/{OrdersTable,LinesManifestView}.js, src/components/sponsors/reports/__tests__/{OrdersTable,LinesManifestView}.test.js	Orders tables and line manifests render report data and add view-specific tests.
Grouped sponsor and component cards src/components/sponsors/reports/{GroupBySponsorView,GroupByComponentView}.js, src/components/sponsors/reports/__tests__/{GroupBySponsorView,GroupByComponentView}.test.js	Sponsor and component grouped cards render report data and add view-specific tests.
Navigation and landing src/components/menu/menu-definition.js, src/i18n/en.json, src/layouts/sponsor-layout.js, src/layouts/sponsor-reports-layout.js, src/layouts/__tests__/sponsor-reports-layout.test.js, src/pages/sponsors/sponsor-reports/reports-landing-page/*	The sponsor reports menu entry, translations, routes, breadcrumbs, landing cards, and layout tests are added.
Purchase details page src/pages/sponsors/sponsor-reports/purchase-details-report-page/*	The purchase-details page builds report queries from filters, sort, and pagination, renders summary tiles and actions, and dispatches report and filter thunks with validation handling.
Sponsor asset pages src/pages/sponsors/sponsor-reports/{sponsor-asset-report-page,sponsor-asset-drilldown-page}/*	The sponsor-asset report and drilldown pages load grouped data, render sponsor and component views, export CSV, and show per-module content states.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Suggested reviewers

• smarcet
• martinquiroga-exo

Poem

🐰 I sniffed the carrots, crisp and bright,
and hopped through reports by day and night.
CSV trails and badges in sight,
sponsor cards gleam soft and light.
Hop-hop, these changes feel just right!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: porting Sponsor Reports into Summit Admin under Sponsors → Reports.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/sponsor-reports-port

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (3)

src/pages/sponsors/sponsor-reports/__tests__/routing.test.js (1)

33-65: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚖️ Poor tradeoff

Test replicates route ordering instead of asserting on the real layout.

Because renderSwitch hand-copies the <Switch> table rather than mounting sponsor-reports-layout.js, it validates React Router's behavior, not the production ordering. If the real layout's route order drifts, this test won't catch it. The drilldown-vs-landing ordering is already covered against the real component in sponsor-reports-layout.test.js, so this can either be removed or driven through the actual layout to guard against regressions.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/pages/sponsors/sponsor-reports/__tests__/routing.test.js` around lines 33
- 65, This test is duplicating the route table instead of exercising the real
sponsor-reports layout, so it won’t catch regressions in the production
ordering. Update the routing coverage to mount sponsor-reports-layout.js
directly (using the existing SponsorReportsLayout or equivalent wrapper) instead
of the local renderSwitch Switch copy, or remove this redundant spec if
sponsor-reports-layout.test.js already covers the drilldown-vs-list ordering.

src/components/sponsors/reports/FilterBar.js (1)

28-29: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚖️ Poor tradeoff

draft won't re-sync if the value prop changes after mount.

useState(value) only seeds the initial state; later changes to the value prop (e.g. an external filter reset) won't be reflected in draft. Current flows keep parent/child in sync manually (Apply commits the draft, Clear resets both to {}), so there's no active bug, but this coupling is fragile if value ever becomes externally driven. Consider syncing via an effect keyed on value if that scenario is anticipated.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/sponsors/reports/FilterBar.js` around lines 28 - 29, The local
draft state in FilterBar is only initialized from the value prop and will not
update if that prop changes later. If external changes to value are expected,
add synchronization in FilterBar using an effect keyed on value so setDraft
stays aligned; keep the update helper unchanged and make sure the draft state
refreshes whenever the incoming value object changes.

src/reducers/sponsors/__tests__/sponsor-reports-reducers.test.js (1)

110-124: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add coverage for PURCHASE_DETAILS_VALIDATION_CLEAR.

This file validates the set path for validationError, but not the clear action branch; add one test to prevent regressions in inline/toast reset flow.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/reducers/sponsors/__tests__/sponsor-reports-reducers.test.js` around
lines 110 - 124, Add a test for the PURCHASE_DETAILS_VALIDATION_CLEAR branch in
purchaseDetailsReducer to cover the reset path for validationError and loading
state. Use the existing PURCHASE_DETAILS_VALIDATION_ERROR test in
sponsor-reports-reducers.test.js as a guide, but assert that dispatching
PURCHASE_DETAILS_VALIDATION_CLEAR clears validationError without replacing the
current data/body so the inline/toast reset flow stays protected.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/actions/sponsor-reports-actions.js`:
- Around line 34-54: Add an early guard in getPurchaseDetailsReport and
getPurchaseDetailsFilters to check that currentSummit and currentSummit.id exist
before calling dispatch(startLoading()) or base(currentSummit.id). If the summit
is missing, exit the thunk immediately (optionally dispatch a validation/error
action) so the synchronous throw never happens and stopLoading() is not skipped.
Keep the fix localized in sponsor-reports-actions.js and use the existing thunk
names to update both purchase-details actions consistently.

In `@src/utils/reports-money.js`:
- Around line 10-13: Update formatUsd in reports-money.js so blank or
whitespace-only strings are treated as missing values instead of being converted
by Number(). Add an explicit check before parsing string input (for example in
the formatUsd path) to return "—" when the value is empty after trimming, while
keeping the existing USD.format behavior for valid numeric values.

---

Nitpick comments:
In `@src/components/sponsors/reports/FilterBar.js`:
- Around line 28-29: The local draft state in FilterBar is only initialized from
the value prop and will not update if that prop changes later. If external
changes to value are expected, add synchronization in FilterBar using an effect
keyed on value so setDraft stays aligned; keep the update helper unchanged and
make sure the draft state refreshes whenever the incoming value object changes.

In `@src/pages/sponsors/sponsor-reports/__tests__/routing.test.js`:
- Around line 33-65: This test is duplicating the route table instead of
exercising the real sponsor-reports layout, so it won’t catch regressions in the
production ordering. Update the routing coverage to mount
sponsor-reports-layout.js directly (using the existing SponsorReportsLayout or
equivalent wrapper) instead of the local renderSwitch Switch copy, or remove
this redundant spec if sponsor-reports-layout.test.js already covers the
drilldown-vs-list ordering.

In `@src/reducers/sponsors/__tests__/sponsor-reports-reducers.test.js`:
- Around line 110-124: Add a test for the PURCHASE_DETAILS_VALIDATION_CLEAR
branch in purchaseDetailsReducer to cover the reset path for validationError and
loading state. Use the existing PURCHASE_DETAILS_VALIDATION_ERROR test in
sponsor-reports-reducers.test.js as a guide, but assert that dispatching
PURCHASE_DETAILS_VALIDATION_CLEAR clears validationError without replacing the
current data/body so the inline/toast reset flow stays protected.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 878ce767-9e7a-43b8-97cf-abd302c54c9b

📥 Commits

Reviewing files that changed from the base of the PR and between d3f018b and 07c3261.

📒 Files selected for processing (57)

• .env.example
• src/actions/__tests__/sponsor-reports-actions.test.js
• src/actions/sponsor-reports-actions.js
• src/app.js
• src/components/menu/menu-definition.js
• src/components/sponsors/reports/ExportCsvButton.js
• src/components/sponsors/reports/FilterBar.js
• src/components/sponsors/reports/GroupByComponentView.js
• src/components/sponsors/reports/GroupBySponsorView.js
• src/components/sponsors/reports/GroupByToggle.js
• src/components/sponsors/reports/OrdersTable.js
• src/components/sponsors/reports/ReportShell.js
• src/components/sponsors/reports/StatusPill.js
• src/components/sponsors/reports/StatusRollupChips.js
• src/components/sponsors/reports/SummaryPanel.js
• src/components/sponsors/reports/TierBadge.js
• src/components/sponsors/reports/__tests__/ExportCsvButton.test.js
• src/components/sponsors/reports/__tests__/FilterBar.test.js
• src/components/sponsors/reports/__tests__/GroupByComponentView.test.js
• src/components/sponsors/reports/__tests__/GroupBySponsorView.test.js
• src/components/sponsors/reports/__tests__/GroupByToggle.test.js
• src/components/sponsors/reports/__tests__/OrdersTable.test.js
• src/components/sponsors/reports/__tests__/ReportShell.test.js
• src/components/sponsors/reports/__tests__/StatusPill.test.js
• src/components/sponsors/reports/__tests__/StatusRollupChips.test.js
• src/components/sponsors/reports/__tests__/SummaryPanel.test.js
• src/components/sponsors/reports/__tests__/TierBadge.test.js
• src/components/sponsors/reports/__tests__/statusTone.test.js
• src/components/sponsors/reports/__tests__/usePrint.test.js
• src/components/sponsors/reports/report-print.css
• src/components/sponsors/reports/statusTone.js
• src/components/sponsors/reports/usePrint.js
• src/i18n/en.json
• src/layouts/__tests__/sponsor-reports-layout.test.js
• src/layouts/sponsor-layout.js
• src/layouts/sponsor-reports-layout.js
• src/pages/sponsors/sponsor-reports/__tests__/routing.test.js
• src/pages/sponsors/sponsor-reports/purchase-details-report-page/__tests__/index.test.js
• src/pages/sponsors/sponsor-reports/purchase-details-report-page/index.js
• src/pages/sponsors/sponsor-reports/reports-landing-page/__tests__/index.test.js
• src/pages/sponsors/sponsor-reports/reports-landing-page/index.js
• src/pages/sponsors/sponsor-reports/sponsor-asset-drilldown-page/__tests__/index.test.js
• src/pages/sponsors/sponsor-reports/sponsor-asset-drilldown-page/index.js
• src/pages/sponsors/sponsor-reports/sponsor-asset-report-page/__tests__/index.test.js
• src/pages/sponsors/sponsor-reports/sponsor-asset-report-page/index.js
• src/reducers/sponsors/__tests__/sponsor-reports-reducers.test.js
• src/reducers/sponsors/sponsor-reports-drilldown-reducer.js
• src/reducers/sponsors/sponsor-reports-purchase-details-reducer.js
• src/reducers/sponsors/sponsor-reports-sponsor-asset-reducer.js
• src/store.js
• src/utils/constants.js
• src/utils/report-errors.js
• src/utils/report-query.js
• src/utils/reports-api.js
• src/utils/reports-money.js
• src/utils/reports-text.js
• src/utils/section-csv-query.js

[Copilot]

Pull request overview

Ports the Sponsor Reports frontend (Purchase Details + Sponsor Assets, including per-sponsor drill-down) into summit-admin under Sponsors → Reports, using the existing admin-sponsors access gate and the in-context summit selection.

Changes:

• Adds a new Sponsor Reports layout + routes (landing, purchase details, sponsor assets, drill-down) and wires it into the Sponsors menu.
• Implements report UI building blocks (report shell, filters, grouping views, CSV export, print) plus supporting query/text/money utilities.
• Introduces Redux actions/reducers for sponsor reports and adds extensive unit/integration test coverage + i18n strings.

Reviewed changes

Copilot reviewed 57 out of 57 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/utils/section-csv-query.js	Builds section-scoped CSV export query while preserving unrelated query params.
src/utils/reports-text.js	HTML-to-plain-text helper for report text fields.
src/utils/reports-money.js	USD formatting helper for report summary/rows.
src/utils/reports-api.js	Reports API base URL helper + positive-int route ID validator.
src/utils/report-query.js	Translates report filter UI state into base-api-utils query params.
src/utils/report-errors.js	Normalizes/classifies report API errors and provides a getRequest-shaped handler factory.
src/utils/constants.js	Adds HTTP 503 constant used by report error classification.
src/utils/tests/reports-money.test.js	Unit tests for USD formatting helper.
src/store.js	Registers sponsor reports reducers and excludes their state from persistence.
src/reducers/sponsors/sponsor-reports-sponsor-asset-reducer.js	Sponsor Assets grouped report reducer.
src/reducers/sponsors/sponsor-reports-purchase-details-reducer.js	Purchase Details report reducer (incl. validation vs read-error split).
src/reducers/sponsors/sponsor-reports-drilldown-reducer.js	Sponsor Assets drill-down reducer.
src/reducers/sponsors/tests/sponsor-reports-reducers.test.js	Reducer unit tests covering all sponsor reports reducers.
src/pages/sponsors/sponsor-reports/sponsor-asset-report-page/index.js	Sponsor Assets grouped report page (group-by, filters, pagination, CSV/print).
src/pages/sponsors/sponsor-reports/sponsor-asset-report-page/tests/index.test.js	Sponsor Assets report page tests (dispatching, toggles, states, CSV props).
src/pages/sponsors/sponsor-reports/sponsor-asset-drilldown-page/index.js	Per-sponsor drill-down page (section cards, content rendering, per-section CSV).
src/pages/sponsors/sponsor-reports/sponsor-asset-drilldown-page/tests/index.test.js	Drill-down page tests including ContentCell behaviors.
src/pages/sponsors/sponsor-reports/reports-landing-page/index.js	Reports landing page with two navigation cards.
src/pages/sponsors/sponsor-reports/reports-landing-page/tests/index.test.js	Landing page tests for cards and links.
src/pages/sponsors/sponsor-reports/purchase-details-report-page/index.js	Purchase Details report page (filters, sorting, pagination, CSV/print, tiles).
src/pages/sponsors/sponsor-reports/purchase-details-report-page/tests/index.test.js	Purchase Details page tests including filter->query behavior and CSV dispatch.
src/layouts/sponsor-reports-layout.js	Sponsor Reports sub-router + breadcrumb composition + admin gate.
src/layouts/sponsor-layout.js	Adds /reports route under Sponsors layout.
src/layouts/tests/sponsor-reports-layout.test.js	Layout routing + Restrict gate integration tests (landing, unauthorized, drilldown, crumbs).
src/i18n/en.json	Adds menu label + Sponsor Reports page strings.
src/components/sponsors/reports/usePrint.js	Hook wrapper around window.print() for reports.
src/components/sponsors/reports/TierBadge.js	Tier badge chip with explicit tier color mapping.
src/components/sponsors/reports/SummaryPanel.js	Shared summary tiles panel component.
src/components/sponsors/reports/statusTone.js	Central status->chip-tone mapping helper.
src/components/sponsors/reports/StatusRollupChips.js	Renders stable-order rollup chips for grouped Sponsor Assets cards.
src/components/sponsors/reports/StatusPill.js	Single status chip component with shared tone mapping.
src/components/sponsors/reports/ReportShell.js	Shared report page shell (header, action slot, filter slot, print CSS hook).
src/components/sponsors/reports/report-print.css	Print-only CSS to print report body.
src/components/sponsors/reports/OrdersTable.js	Purchase Details table built on uicore MuiTable + date/time formatting helpers.
src/components/sponsors/reports/GroupByToggle.js	Toggle for sponsor/component grouping mode.
src/components/sponsors/reports/GroupBySponsorView.js	Sponsor-grouped card list with drill-down links.
src/components/sponsors/reports/GroupByComponentView.js	Component-grouped card list with per-sponsor links and content previews.
src/components/sponsors/reports/FilterBar.js	Shared report filter bar (sponsor multiselect + optional search + extra controls).
src/components/sponsors/reports/ExportCsvButton.js	CSV export button integrating uicore getCSV and access token retrieval.
src/components/sponsors/reports/tests/usePrint.test.js	Unit test for print hook.
src/components/sponsors/reports/tests/TierBadge.test.js	Unit tests for TierBadge rendering behavior.
src/components/sponsors/reports/tests/SummaryPanel.test.js	Unit tests for SummaryPanel rendering and empty behavior.
src/components/sponsors/reports/tests/statusTone.test.js	Unit tests for status tone mapping helper.
src/components/sponsors/reports/tests/StatusRollupChips.test.js	Unit tests for rollup chips ordering and null rollup behavior.
src/components/sponsors/reports/tests/StatusPill.test.js	Unit tests for StatusPill label behavior and tone mapping re-export.
src/components/sponsors/reports/tests/ReportShell.test.js	Unit tests for ReportShell slots and icon rendering.
src/components/sponsors/reports/tests/OrdersTable.test.js	Unit tests for table helpers and basic rendering/sort interactions.
src/components/sponsors/reports/tests/GroupByToggle.test.js	Unit tests for group toggle behavior (ignore null toggle).
src/components/sponsors/reports/tests/GroupBySponsorView.test.js	Unit tests for sponsor-grouped card rendering and link targets.
src/components/sponsors/reports/tests/GroupByComponentView.test.js	Unit tests for component-grouped rendering, content hints, and links.
src/components/sponsors/reports/tests/FilterBar.test.js	Unit tests for FilterBar sponsorIds emission and optional search box.
src/components/sponsors/reports/tests/ExportCsvButton.test.js	Unit tests for CSV dispatch args, disabling, and in-flight click guard.
src/components/menu/menu-definition.js	Adds Sponsors → Reports menu entry guarded by admin-sponsors.
src/app.js	Injects SPONSOR_REPORTS_API_URL into window config.
src/actions/sponsor-reports-actions.js	Thunks for reports endpoints (purchase details, sponsor assets, filters, drilldown).
src/actions/tests/sponsor-reports-actions.test.js	Unit tests for sponsor reports thunks and read-error handler behavior.
.env.example	Adds SPONSOR_REPORTS_API_URL example env var.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.env.example:
- Line 26: The SCOPES aggregate still includes reports/all, which is broader
than needed and conflicts with the dedicated sponsor report scopes. Update the
SCOPES value in .env.example to remove reports/all while keeping the existing
scoped report permissions such as SPONSOR_REPORTS_SCOPES and the other named
scope variables intact.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 05a2e27c-7d13-497e-bd72-9787506508fa

📥 Commits

Reviewing files that changed from the base of the PR and between 07c3261 and d342f26.

📒 Files selected for processing (12)

• .env.example
• src/actions/__tests__/sponsor-reports-actions.test.js
• src/actions/sponsor-reports-actions.js
• src/components/sponsors/reports/FilterBar.js
• src/reducers/sponsors/__tests__/sponsor-reports-reducers.test.js
• src/utils/__tests__/report-query.test.js
• src/utils/__tests__/reports-money.test.js
• src/utils/__tests__/reports-text.test.js
• src/utils/report-errors.js
• src/utils/report-query.js
• src/utils/reports-money.js
• src/utils/reports-text.js

✅ Files skipped from review due to trivial changes (2)

• src/utils/tests/reports-text.test.js
• src/utils/tests/reports-money.test.js

🚧 Files skipped from review as they are similar to previous changes (5)

• src/utils/reports-money.js
• src/utils/report-query.js
• src/utils/report-errors.js
• src/reducers/sponsors/tests/sponsor-reports-reducers.test.js
• src/actions/tests/sponsor-reports-actions.test.js

[smarcet]

Two low-severity findings from the deep review — both are code-quality nits with no functional impact on the feature. @caseylocker tagging you for awareness.

[smarcet]

Convention audit against the established codebase patterns. 4 inline findings below — none are blockers, but two are 1-line fixes. @caseylocker

[smarcet]

Addressing the two remaining false positives from CodeRabbit's nitpick summary (review #4567585391):

---

FilterBar.js:28-29 — draft won't re-sync if value prop changes after mount

The useEffect that re-syncs draft to the committed value prop is already there:

useEffect(() => {
  setDraft(value);
}, [value]);

The comment above it even explains the intent: "Re-sync the draft when the committed value prop changes externally (e.g. a parent-driven reset)." The finding describes exactly what the code already does.

---

sponsor-reports-reducers.test.js:110-124 — missing test for PURCHASE_DETAILS_VALIDATION_CLEAR

The test is present, starting at line 127:

describe("PURCHASE_DETAILS_VALIDATION_CLEAR", () => {
  it("clears validationError without replacing the body", () => {
    ...
    expect(result.validationError).toBeNull();
  });
});

CodeRabbit scanned lines 110–124 (the set path) and didn't look at the lines immediately following.

[smarcet]

@caseylocker please review

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/pages/sponsors/sponsor-reports/purchase-details-report-page/index.js`:
- Around line 126-141: The three effects in
purchase-details-report-page/index.js are missing the in-context summit as a
dependency, so they won’t rerun when the summit changes after mount. Update the
useEffect hooks that call fetchFilters, fetchReport, and fetchLinesReport to
depend on currentSummit?.id (or the equivalent summit identifier from the
component scope) along with the existing inputs so the page refetches filters
and reports when the active summit is hydrated or switched. Keep the mount-only
behavior only if it still includes summit changes as a trigger for the
data-loading effects.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aceb4674-64b2-4907-afd9-8c0ad10a05a7

📥 Commits

Reviewing files that changed from the base of the PR and between d342f26 and c1cc057.

📒 Files selected for processing (14)

• src/actions/__tests__/sponsor-reports-actions.test.js
• src/actions/sponsor-reports-actions.js
• src/components/sponsors/reports/LinesManifestView.js
• src/components/sponsors/reports/ReportViewToggle.js
• src/components/sponsors/reports/__tests__/LinesManifestView.test.js
• src/components/sponsors/reports/__tests__/ReportViewToggle.test.js
• src/i18n/en.json
• src/pages/sponsors/sponsor-reports/purchase-details-report-page/__tests__/index.test.js
• src/pages/sponsors/sponsor-reports/purchase-details-report-page/index.js
• src/reducers/sponsors/__tests__/sponsor-reports-purchase-details-lines-reducer.test.js
• src/reducers/sponsors/sponsor-reports-purchase-details-lines-reducer.js
• src/store.js
• src/utils/__tests__/manifest-grouping.test.js
• src/utils/manifest-grouping.js

✅ Files skipped from review due to trivial changes (1)

• src/utils/manifest-grouping.js

🚧 Files skipped from review as they are similar to previous changes (3)

• src/store.js
• src/i18n/en.json
• src/actions/tests/sponsor-reports-actions.test.js

[coderabbitai]

🧹 Nitpick comments (1)

src/pages/sponsors/sponsor-reports/purchase-details-report-page/index.js (1)

196-208: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Optional: fold the duplicated CSV url/query derivation into a small helper.

linesCsvUrl/linesCsvQuery repeat the exact base-URL construction and page/per_page stripping already done for the orders export just above. A tiny helper (e.g. buildCsv(path, srcQuery) returning { url, query }) would remove the copy and keep both exports in sync if the strip rules change.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/pages/sponsors/sponsor-reports/purchase-details-report-page/index.js`
around lines 196 - 208, The CSV export setup for purchase details duplicates the
same URL construction and pagination-stripping logic already used for the orders
export. Extract that repeated logic into a small shared helper in this page (for
example, a function that builds the CSV url and query from a path and source
query), then use it for both exports so `linesCsvUrl` and `linesCsvQuery` stay
aligned with the existing order export behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/pages/sponsors/sponsor-reports/purchase-details-report-page/index.js`:
- Around line 196-208: The CSV export setup for purchase details duplicates the
same URL construction and pagination-stripping logic already used for the orders
export. Extract that repeated logic into a small shared helper in this page (for
example, a function that builds the CSV url and query from a path and source
query), then use it for both exports so `linesCsvUrl` and `linesCsvQuery` stay
aligned with the existing order export behavior.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a24726cb-2af3-4f33-a505-8cb87decc70c

📥 Commits

Reviewing files that changed from the base of the PR and between 645fe0c and 809356f.

📒 Files selected for processing (2)

• src/pages/sponsors/sponsor-reports/purchase-details-report-page/__tests__/index.test.js
• src/pages/sponsors/sponsor-reports/purchase-details-report-page/index.js

[santipalenque]

Hey @caseylocker, this PR doesn't follow our codebase's coding patterns. For example, you added several files to the utils dir that are specific to these reports. No other page or section of the admin does this — if it did, utils would end up with dozens of one-off files, defeating the purpose of having a generic utils dir.

I left a few examples inline. Could you go through the PR and align the solution with summit-admin's coding patterns?

[caseylocker]

Hey @caseylocker, this PR doesn't follow our codebase's coding patterns. For example, you added several files to the utils dir that are specific to these reports. No other page or section of the admin does this — if it did, utils would end up with dozens of one-off files, defeating the purpose of having a generic utils dir.

I left a few examples inline. Could you go through the PR and align the solution with summit-admin's coding patterns?

@santipalenque Thank you very much for the excellent review. These are great callouts and will help me to align closer with code patterns in the project going forward. I believe that I've addressed all of your concerns with the latest push. Let me know if I missed something, especially with this one #997 (comment).

[santipalenque]

Hey @caseylocker, thanks for the fixes. It looks like only the inline-commented spots were addressed — could you go through the rest of the PR and check for similar coding pattern issues elsewhere, not just the ones I flagged?

[santipalenque]

a few nits and another one that I think is out of scope, once nits are fixed I think we are good to go @smarcet . pre-approving - good job @caseylocker !

[santipalenque]

@smarcet I think this should be a broader solution since this an issue across all api calls

[smarcet]

@santipalenque i do agree i will open a ticket many thanks

[santipalenque]

use createAction

[caseylocker]

Done in 68961e2. It's a thunk dispatching createAction(PURCHASE_DETAILS_VALIDATION_CLEAR)({}) now, same shape as clearCurrentSummit / resetTicketTypeForm.

[santipalenque]

we don't need this as a constant, you can just set the default value in the props

[caseylocker]

@santipalenque, kept this one deliberately, an inline {} default creates a fresh object identity on every render, which re-fires the useEffect([value]) draft-resync > setDraft > re-render > new {}, and the loop self-sustains ("Maximum update depth exceeded"). The module-level constant gives the omitted-prop case a stable identity; there's now a test that exercises the omitted-value path and blows up if this ever regresses to an inline default. If you still want the change I'm happy to make it, just wanted to call out my reasoning first.

[santipalenque]

can we use TONE_BY_STATUS in StatusPill ?

[caseylocker]

Yep. Dropped the local TILE_TONE and the tiles now use statusTone() exported from StatusPill, so the tone map lives in one place. In 68961e2.

[santipalenque]

This same list of keys is duplicated in build-pivot-tree.js and StatusRollupChips.js

[caseylocker]

Fixed in 68961e2. STATUS_KEYS is exported once from build-pivot-tree (it's what computes the rollup those keys describe) and StatusRollupChips + the report page import it. Also derived the rollup's zero-init from the same array, which was a fourth hidden copy.

[smarcet]

@caseylocker please review comments

[caseylocker]

@caseylocker please review comments

@smarcet all of santi's comments are handled as of 68961e2: three fixed (createAction, tone map reuse, STATUS_KEYS dedup), and I replied on the FilterBar constant one with my reasoning for keeping it (inline {} default loops the resync effect, there's a test guarding it now). I see your response to the seq-guard one so didn't make any changes there. Replies are on each thread, ready for your re-review.

[smarcet]

@caseylocker please review #997 (comment)

[smarcet]

LGTM