Create shareable ESLint config#8
Merged
Merged
Conversation
mrclay
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a recent GitHub audit, Mark unearthed this repo, which contained some (very old) shareable ESLint configs. I'm repurposing it for anything we want as npm packages shareable between various sites (and Gesso React/Gesso Drupal), starting with updating the ESLint config.
Back in November, we decided to move away from the Airbnb ESLint standard in order to upgrade to ESLint 9 and to try to better align linting standards between Gesso flavors. This PR takes the first step by creating a shareable base JS/TS config and a React-specific config that can be added for JSX files. Rules and overrides come primarily from gesso and/or nextjs-project, though I also looked at what the ETS React library had in use and pulled a few from there.
Next steps are to publish the updated packages and then convert Gesso/Next.js starter to use ESLint 9 and extend the shared config.