Use CPP so we can work with http-client pre and post 0.5 - #17
Merged
Conversation
| #if MIN_VERSION_http_client(0, 5, 0) | ||
| HC.defaultRequest | ||
| { HC.checkResponse = \_ _ -> return () | ||
| , HC.responseTimeout = maybe HC.responseTimeoutNone (HC.responseTimeoutMicro . (1000 *)) $ lpsTimeBound lps |
Contributor
There was a problem hiding this comment.
I don't think the 1000 * is correct/necessary here, aren't both values in microseconds?
Contributor
Author
There was a problem hiding this comment.
Yes, I was wondering that :) but fiveMinutes is in milliseconds (5 * 60 * 1000) i.e. 1/1000; microseconds are 1/1000000.
I was not checking the underlying implementation; just the name.
Contributor
|
Thanks! |
Contributor
Author
|
happy to help :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The api for http-client changed slightly this CPP allows to use the newer version