fix(alert): Handle missing conditions/actions in issue alert view - #1331
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sentry alert issues viewcommand would crash with a TypeError when the Sentry API's/workflows/endpoint omitted theconditionsoractionsarrays for an issue alert rule. This happened becauseformatIssueAlertViewinpackages/cli/src/commands/alert/issues/view.tsdirectly accessed.lengthon these potentially undefined properties.This fix addresses the issue by:
IssueAlertRuletype inpackages/cli/src/lib/api/alerts.tsto markconditionsandactionsas optional (?: unknown[]), accurately reflecting the API's behavior.formatIssueAlertViewto use optional chaining and nullish coalescing (rule.conditions?.length ?? 0andrule.actions?.length ?? 0), ensuring that0is displayed if these properties are missing, preventing the TypeError.Fixes CLI-2CY
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.