doc(java): Global tags/extra with logback appender encoder - #1379
Merged
Conversation
bruno-garcia
requested changes
Nov 29, 2019
bruno-garcia
left a comment
bruno-garcia
left a comment
Member
There was a problem hiding this comment.
Small changes suggested.
Other than that LGTM, @MimiDumpling will give the final approval before we merge/
Member
|
@jeacott1 Thanks for this btw, awesome work! |
bruno-garcia
changed the title
Co-Authored-By: Bruno Garcia <bruno@brunogarcia.com>
Co-Authored-By: Bruno Garcia <bruno@brunogarcia.com>
Co-Authored-By: Bruno Garcia <bruno@brunogarcia.com>
MimiDumpling
reviewed
Dec 2, 2019
MimiDumpling
left a comment
MimiDumpling
left a comment
Contributor
There was a problem hiding this comment.
Just a couple suggested edits. 😸
Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds documentation for global tags and extras using the logback appender.
I'm not sure what the target version is likely to be however? unlikely to remain 1.7.27