Skip to content

Docs for HTTP Client errors OkHttp - #5651

Merged
marandaneto merged 19 commits into
masterfrom
chore/http-client-errors
Oct 20, 2022
Merged

Docs for HTTP Client errors OkHttp#5651
marandaneto merged 19 commits into
masterfrom
chore/http-client-errors

Conversation

@marandaneto

@marandaneto marandaneto commented Oct 17, 2022

Copy link
Copy Markdown
Contributor

Blocked by getsentry/sentry-java#2287 till it gets released.

@marandaneto
marandaneto requested a review from a team as a code owner October 17, 2022 08:12
@vercel

vercel Bot commented Oct 17, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Oct 20, 2022 at 8:34AM (UTC)

Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated

@imatwawana imatwawana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made style and wording edits. Ping me when you've made updates and I'll take another look.

Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
marandaneto and others added 11 commits October 17, 2022 15:59
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

@imatwawana imatwawana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple things I missed the first time, but otherwise looks good.

Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
marandaneto and others added 3 commits October 17, 2022 16:59
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

@philipphofmann philipphofmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs, thanks 🙏

Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx Outdated
Comment thread src/platforms/android/configuration/integrations/okhttp.mdx
marandaneto and others added 2 commits October 20, 2022 10:00
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
@marandaneto

Copy link
Copy Markdown
Contributor Author

Thanks for the review you all.

@marandaneto
marandaneto marked this pull request as ready for review October 20, 2022 15:39
@marandaneto
marandaneto merged commit f24c57e into master Oct 20, 2022
@marandaneto
marandaneto deleted the chore/http-client-errors branch October 20, 2022 15:39
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants