Skip to content

feat: Add compose module (navigation) - #2121

Merged
romtsn merged 10 commits into
feat/androidx-navigationfrom
feat/androidx-compose
Jun 24, 2022
Merged

feat: Add compose module (navigation)#2121
romtsn merged 10 commits into
feat/androidx-navigationfrom
feat/androidx-compose

Conversation

@romtsn

@romtsn romtsn commented Jun 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

#skip-changelog

📜 Description

  • Adds Jetpack compose module (multiplatform setup to later support Compose/Desktop)
  • Adds support for instrumenting NavController in compose

💡 Motivation and Context

Part of #2096

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next step

@romtsn
romtsn requested a review from adinauer as a code owner June 21, 2022 15:54
@romtsn
romtsn changed the base branch from main to feat/androidx-navigation June 21, 2022 15:55
@romtsn
romtsn requested a review from marandaneto as a code owner June 21, 2022 15:55
romtsn
romtsn commented Jun 21, 2022
View reviewed changes
Comment thread sentry-compose/src/androidMain/kotlin/io/sentry/compose/SentryNavigationIntegration.kt Outdated
@romtsn romtsn changed the title Add compose module feat: Add compose module (navigation) Jun 21, 2022
@github-actions

github-actions Bot commented Jun 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 17f80f5

romtsn
romtsn commented Jun 21, 2022
View reviewed changes
Comment thread buildSrc/src/main/java/Config.kt
romtsn
romtsn commented Jun 21, 2022
View reviewed changes
Comment thread buildSrc/src/main/java/Config.kt
marandaneto
marandaneto reviewed Jun 22, 2022
View reviewed changes
Comment thread buildSrc/src/main/java/Config.kt Outdated
marandaneto
marandaneto reviewed Jun 22, 2022
View reviewed changes
Comment thread sentry-compose/build.gradle.kts Outdated
adinauer
adinauer approved these changes Jun 22, 2022
View reviewed changes

@adinauer adinauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romtsn romtsn mentioned this pull request Jun 22, 2022
Closed
9 tasks
@romtsn
romtsn merged commit c94942e into feat/androidx-navigation Jun 24, 2022
@romtsn
romtsn deleted the feat/androidx-compose branch June 24, 2022 11:06
romtsn added a commit that referenced this pull request Jun 24, 2022
@romtsn
feat: Add sentry-android-navigation module (#2116)
b141252 
* feat: Add compose module (navigation) (#2121)
* feat: Add compose sample (#2122)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adinauer adinauer adinauer approved these changes
+1 more reviewer
@marandaneto marandaneto marandaneto left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romtsn @adinauer @marandaneto