Missing unit fields for Android measurements - #2204
Merged
Merged
Conversation
Contributor
Author
|
This has to change, making a draft for now. |
marandaneto
marked this pull request as draft
August 4, 2022 14:11
Member
|
@marandaneto, this PR has been lying around for a while. What can we do to move it forward? |
Member
Should be fixed now. Do you want to give my changes a review or can I merge this? Would need it for measurements. |
Contributor
Author
All good from my side, I can't approve my own PR, feel free to fix the conflicts and merge it, thanks for fixing this. |
adinauer
marked this pull request as ready for review
September 6, 2022 05:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added missing unit field.
Added support for unknown fields in case new types come from Hybrid SDKs.
💡 Motivation and Context
Fix #2150
Part of getsentry/team-mobile#31
💚 How did you test it?
📝 Checklist
🔮 Next steps