feat(server-utils): Capture and log orchestrion stats#22269
Merged
Conversation
timfish
requested review from
Lms24,
andreiborza,
isaacs and
logaretm
and removed request for
a team
July 14, 2026 21:14
![cursor[bot]](https://cdn.github.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
size-limit report 📦
|
![sentry[bot]](https://cdn.github.com/in/12637?s=60&v=4){kind=small}
JPeer264
reviewed
Jul 15, 2026
| * orchestrion bundler plugin. | ||
| * | ||
| * `injectDiagnostics` sets `globalThis.__SENTRY_ORCHESTRION__.bundler = true` at | ||
| * `injectDiagnostics` sets `globalThis.__SENTRY_ORCHESTRION__.bundler = ["mysql"]` at |
|
|
||
| // Already injected (runtime --import hook or bundler plugin) — nothing to do. | ||
| if (g.runtime) { | ||
| if (GLOBAL_OBJ?.__SENTRY_ORCHESTRION__?.runtime) { |
Member
There was a problem hiding this comment.
m: Shouldn't this be the following?
Suggested change
| if (GLOBAL_OBJ?.__SENTRY_ORCHESTRION__?.runtime) { | |
| if (!!GLOBAL_OBJ?.__SENTRY_ORCHESTRION__?.runtime.length) { |
Collaborator
Author
There was a problem hiding this comment.
No, an empty array signifies that the the hooks have been setup:
| '(mysql, …) will not record spans. Make sure the diagnostics channels are injected ' + | ||
| 'via the runtime `--import` hook or a bundler plugin before the instrumented modules load.', | ||
| ); | ||
| if (!runtime && !bundler) { |
Member
There was a problem hiding this comment.
l/m: Also here. We should check for the array length, right?
Collaborator
Author
There was a problem hiding this comment.
If either of these are defined, we will hit the debug logging below with more details for each.
JPeer264
approved these changes
Jul 15, 2026
timfish
enabled auto-merge (squash)
July 15, 2026 13:49
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
debug: true