chore(skills): Add bump-conventions skill#22271
Conversation
55e3de3 to
7cfea00
Compare
![cursor[bot]](https://cdn.github.com/in/1210556?s=60&v=4){kind=small}
8bc44dc to
db12944
Compare
Co-Authored-By: Opus 4.8 <noreply@anthropic.com>
db12944 to
4a331a4
Compare
nicohrubec
left a comment
nicohrubec
left a comment
There was a problem hiding this comment.
was #22270 the test run with this?
| feat(deps): Bump `@sentry/conventions` to <NEW> | ||
| ``` | ||
|
|
||
| Follow the repo's commit and PR conventions (target `develop`, draft PR, `## What` / `## Why`). Do **not** create the commit yourself unless the user invokes `/commit-push-pr`. |
There was a problem hiding this comment.
do we have such a skill? I don't see it in here: https://github.com/getsentry/sentry-javascript/tree/develop/.agents/skills
There was a problem hiding this comment.
Nope that's my local skill. Will remove, thanks for catching.
There was a problem hiding this comment.
Removed the entire line.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 11ce45a. Configure here.
| ```bash | ||
| yarn circularDepCheck | ||
| yarn fix | ||
| yarn test |
There was a problem hiding this comment.
Skips integration test verification
Medium Severity
The skill’s API-fix and final verification steps rely on yarn build:dev and root yarn test, but several dev-packages/*-integration-tests suites import @sentry/conventions/attributes directly and are excluded from root yarn test. A conventions API break there can pass this checklist yet still fail CI integration jobs.
Reviewed by Cursor Bugbot for commit 11ce45a. Configure here.
![sentry[bot]](https://cdn.github.com/in/12637?s=60&v=4){kind=small}
|
|
||
| After fixing, re-run `yarn build:dev` and confirm it passes before verifying, so the next step runs against fresh build output. | ||
|
|
There was a problem hiding this comment.
Bug: The SKILL.md guide is missing a yarn build:dev step after fixing code changes and before running yarn test, causing tests to run against stale build artifacts.
Severity: MEDIUM
Suggested Fix
Update the SKILL.md instructions to add a yarn build:dev command after Step 4 (fixing breaking changes) and before Step 5 (verification with yarn test). This will ensure that the code is re-compiled and tests are run against the latest changes.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: .agents/skills/bump-conventions/SKILL.md#L47-L49
Potential issue: The instructions in `SKILL.md` contain a logical sequencing error. Step
4 directs the user to fix breaking API changes in the source code, but Step 5 proceeds
directly to testing with `yarn test` without an intermediate build step. The `yarn test`
command runs against previously compiled JavaScript artifacts, which become stale after
the code is modified in Step 4. Consequently, the tests are not validating the recent
fixes but are instead running against outdated code. This issue is confirmed by a commit
message in the pull request, "Re-run build:dev after breaking-change fixes before
verification," which indicates the author's intent but was not reflected in the
documentation.
Did we get this right? 👍 / 👎 to inform future reviews.
Co-authored-by: Charly Gomez <charly.gomez1310@gmail.com>
Co-authored-by: Charly Gomez <charly.gomez1310@gmail.com>
3 participants
What
Add a
bump-conventionsskill that bumps@sentry/conventionsto a new version across everypackage.jsonin the monorepo, preserving the two pin styles (caret for runtime packages, exact for dev-package test suites), refreshingyarn.lock, and running the standard build/dedupe/verify chain.Why
Bumping
@sentry/conventionstouches ~two dozen files and has two distinct pin conventions that are easy to get wrong by hand. The skill makes the bump a single repeatable step.