ref(node): Refactor some otel internals in http integrations#22292
Merged
Conversation
![cursor[bot]](https://cdn.github.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2e9ba2e. Configure here.
| response.resume(); | ||
| } | ||
| setIncomingResponseSpanData(response, span); | ||
| bindScopeToEmitter(response); |
There was a problem hiding this comment.
Response binding omits active span
Medium Severity
Outgoing HTTP responses call bindScopeToEmitter without first activating the outgoing http.client span. bindScopeToEmitter freezes whatever scope is current at bind time, but that span is created via startInactiveSpan, so listeners on the response stream later run without that span active and child spans can attach to the wrong parent.
Reviewed by Cursor Bugbot for commit 2e9ba2e. Configure here.
Member
Author
There was a problem hiding this comment.
this is fine and also how it was before, the emitter should not have the span as parent as that could break parent-child relationships 🤔
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
July 15, 2026 12:51
mydea
requested review from
logaretm,
nicohrubec and
s1gr1d
and removed request for
a team
July 15, 2026 12:51
s1gr1d
approved these changes
Jul 15, 2026
nicohrubec
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors some http integration internals to use core APIs instead of OTEL APIs:
bindScopeToEmitterdirectly now for outgoing requests, this is no longer OTEL specific and thus does not need to be in node-core specifically