Skip to content

ref: Move global error handler+ promise rejection - #2475

Merged
HazAT merged 2 commits into
masterfrom
ref-globalerror-promise
Mar 9, 2020
Merged

ref: Move global error handler+ promise rejection#2475
HazAT merged 2 commits into
masterfrom
ref-globalerror-promise

Conversation

@HazAT

@HazAT HazAT commented Mar 6, 2020

Copy link
Copy Markdown
Member

We need this to mark a transaction as failed if a global unhandled error occurs.

I couldn't move to addEventListener since it doesn't work well with the loader.

@HazAT
HazAT requested a review from kamilogorek as a code owner March 6, 2020 12:49
@HazAT HazAT self-assigned this Mar 6, 2020
@getsentry-bot

getsentry-bot commented Mar 6, 2020

Copy link
Copy Markdown
Contributor
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.7412 kB) (ES6: 15.7559 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 029ed99

@kamilogorek kamilogorek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@HazAT

HazAT commented Mar 9, 2020

Copy link
Copy Markdown
Member Author

In our tests I trust

@HazAT
HazAT merged commit dd7bf92 into master Mar 9, 2020
@HazAT
HazAT deleted the ref-globalerror-promise branch March 9, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants