fix(apm): Use Performance API for timings when available - #2492
Merged
Conversation
HazAT
requested changes
Mar 12, 2020
Instead of downgrading to use the dumb performanceFallback, in the absence of a timeOrigin we can use INITIAL_TIME. This should give better timings in Safari Web Workers.
rhcarvalho
force-pushed
the
rhcarvalho/apm-initial-time-fallback
branch
from
March 12, 2020 10:28
686ac79 to
01a4402
Compare
Contributor
Contributor
Author
Have it locally, will wait to see a green from CI to avoid restarting the dance. (and prob. ignore browserstack) |
Contributor
Author
This was referenced Mar 16, 2020
This was referenced Mar 23, 2020
This was referenced Apr 7, 2020
This was referenced Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of downgrading to use the dumb performanceFallback, in the
absence of a timeOrigin we can use INITIAL_TIME.
This should give better timings in Safari Web Workers.