fix: Revert bad string replacements - #2513
Conversation
Fixes changes introduced in 8c60b1e. Global string replacement was too eager and broke things in raven-node (although development head is actually in the 4.x branch). Other than that, this commit fixes doc comments and an entry in packages/typescript/package.json.
| "author": "Sentry", | ||
| "license": "BSD-3-Clause", | ||
| "private _": false, | ||
| "private": false, |
There was a problem hiding this comment.
Since this was broken for quite some time, is this key actually relevant? Isn't "private": false the default?
|
|
||
| /** | ||
| * Requires a module which is protected _against bundler minification. | ||
| * Requires a module which is protected against bundler minification. |
There was a problem hiding this comment.
This is what got me started... I thought "why _against?!". The rest is Git history.
|
Lint failure was introduced in #2510, broken in master it seems. https://travis-ci.com/github/getsentry/sentry-javascript/jobs/302473023 |
|
This is the failed build from #2510: https://travis-ci.com/github/getsentry/sentry-javascript/jobs/301043705 @kamilogorek what would you suggest here, a |
|
Merged with master to pick up changes that should fix the lint error. |
|
All the new failures (all builds in the job): |
|
Fixed and merged manually |
Fixes changes introduced in 8c60b1e.
Global string replacement was too eager and broke things in raven-node (although development head is actually in the 4.x branch). Other than that, this commit fixes doc comments and an entry in
packages/typescript/package.json.