wgpu.h: Don't require preprocessing to use. - #359
Merged
rajveermalviya merged 1 commit intoJan 27, 2024
Conversation
Contributor
Author
|
I ran across this while working on some cmake stuff regarding #251 cc: @eliemichel |
rajveermalviya
approved these changes
Jan 27, 2024
rajveermalviya
left a comment
rajveermalviya
left a comment
Collaborator
There was a problem hiding this comment.
Great work!
Apart from one nit LGTM.
Right now, `wgpu.h` can be included directly and it then includes `webgpu-headers/webgpu.h`. This is altered during creation of a distribution package to remove the `"webgpu-headers"`, but by adding `ffi/webgpu-headers` to the include search path, we can avoid having to preprocess the `wgpu.h`.
waywardmonkeys
force-pushed
the
no-preprocessing-wgpu.h
branch
from
January 27, 2024 13:50
ce65609 to
95e4a6b
Compare
Contributor
Author
|
@rajveermalviya Hopefully good to go now! |
rajveermalviya
approved these changes
Jan 27, 2024
rajveermalviya
left a comment
rajveermalviya
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! LGTM
Verified locally that the generated package remains the same.
Contributor
Author
|
Thanks… another Pr coming up soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now,
wgpu.hcan be included directly and it then includeswebgpu-headers/webgpu.h. This is altered during creation of a distribution package to remove the"webgpu-headers", but by addingffi/webgpu-headersto the include search path, we can avoid having to preprocess thewgpu.h.