This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Update octokit to 0.29.0 - #1521
Merged
Merged
Conversation
This was referenced Mar 6, 2018
shana
changed the base branch from
feature/pr-reviews-master
to
feature/graphql-modelservice-pr-reviews
March 9, 2018 16:44
shana
changed the base branch from
feature/graphql-modelservice-pr-reviews
to
feature/pr-reviews-master
March 9, 2018 16:46
shana
changed the base branch from
feature/pr-reviews-master
to
feature/graphql-modelservice-pr-reviews
March 9, 2018 16:48
shana
approved these changes
Mar 9, 2018
grokys
force-pushed
the
feature/graphql-modelservice-pr-reviews
branch
from
March 19, 2018 09:11
c649c25 to
0a20262
Compare
This is integrated a bit hackily into `ModelService`; `ModelService` doesn't really mesh well with GraphQL but without a lot of refactoring this was the best way to get things up and running.
grokys
force-pushed
the
update/octokit-to-0.29.0
branch
from
March 19, 2018 09:26
9349655 to
9353f41
Compare
grokys
changed the base branch from
feature/graphql-modelservice-pr-reviews
to
feature/pr-reviews-master
March 19, 2018 09:27
jcansdale
changed the base branch from
feature/pr-reviews-master
to
feature/pr-reviews
March 28, 2018 13:36
jcansdale
changed the base branch from
feature/pr-reviews
to
feature/pr-reviews-master
March 28, 2018 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR reviews feature needs an updated octokit. This PR updates our octokit to the latest release 0.29.0.
Depends on #1501
Depends on editor-tools/octokit.net#4
Part of #1491