Bump minimum CodeQL bundle version to 2.6.3 - #1358
Merged
Merged
Conversation
Contributor
|
Our docs for direct CodeQL CLI use recommend CodeQL 2.6.3 even for GHES 3.1 and 3.2, so this bump is acceptable even if we have a few customers gradually upgrading from deprecated GHES versions. |
henrymercer
force-pushed
the
henrymercer/require-cli-2.6.3
branch
from
November 11, 2022 18:37
c3f3b6e to
2da27c1
Compare
We now only need to support doing this in the CLI.
It is 2.8.2, not 2.7.3.
henrymercer
force-pushed
the
henrymercer/require-cli-2.6.3
branch
from
November 11, 2022 19:09
e191774 to
0c3e493
Compare
henrymercer
marked this pull request as ready for review
November 11, 2022 19:32
Contributor
Author
|
All checks have passed. The PR isn't green yet since it updates the checks to use newer bundle versions. |
aeisenberg
previously approved these changes
Nov 14, 2022
aeisenberg
left a comment
aeisenberg
left a comment
Contributor
There was a problem hiding this comment.
Change looks good. Nice to get rid of some code. Looks like there are some merge conflicts now, though.
Contributor
Author
|
Resolved conflicts by rerunning the workflow generator and rebuilding the Action. |
henrymercer
changed the base branch from
main
to
henrymercer/delete-runner-part-2
November 15, 2022 20:58
aeisenberg
approved these changes
Nov 15, 2022
3 tasks
7 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that GHES 3.2 is deprecated, we can clean up a bunch of tech debt in the Action by bumping our minimum CodeQL Bundle version to 2.6.3, the first version that went into GHES 3.3.
The highlight here is that the Action no longer needs to count lines of code itself, since now all supported versions of the CLI can do that. This allows us to remove a bunch of code and 14 dependencies!
Merge / deployment checklist