Skip to content

C++: Fix FP in cpp/incorrectly-checked-scanf - #15456

Merged
MathiasVP merged 4 commits into
github:mainfrom
MathiasVP:fix-scanf-fp
Jan 29, 2024
Merged

C++: Fix FP in cpp/incorrectly-checked-scanf#15456
MathiasVP merged 4 commits into
github:mainfrom
MathiasVP:fix-scanf-fp

Conversation

@MathiasVP

Copy link
Copy Markdown
Contributor

Note that, because the cpp/missing-check-scanf query only raises an alert if cpp/incorrectly-checked-scanf doesn't, by fixing the FP in cpp/incorrectly-checked-scanf we're now moving the alert to the cpp/missing-check-scanf query.

This is a good trade-off since cpp/incorrectly-checked-scanf is a high-precision query, and cpp/missing-check-scanf is only at precision medium.

I tried to fix the FP in cpp/incorrectly-checked-scanf as well, but this is more difficult. So I think we should get this fix in first before trying to fix the cpp/incorrectly-checked-scanf case.

@github-actions github-actions Bot added the C++ label Jan 29, 2024
@MathiasVP
MathiasVP marked this pull request as ready for review January 29, 2024 13:47
@MathiasVP
MathiasVP requested a review from a team as a code owner January 29, 2024 13:47

@jketema jketema left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if DCA is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants