Conversation
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Contributor
Test Coverage Report
Coverage ThresholdsThe project has the following coverage thresholds configured:
Coverage report generated by `npm run test:coverage` |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds wildcard domain support to the domain allowlist functionality. Users can now specify patterns like *.github.com or api-*.example.com in addition to plain domains like github.com.
Key changes:
- Adds a new
domain-patterns.tsmodule with wildcard pattern parsing, validation, and regex conversion - Updates Squid configuration generation to use both
dstdomainACLs (for plain domains) anddstdom_regexACLs (for wildcard patterns) - Adds CLI validation for domain patterns with comprehensive error messages for overly broad patterns
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/domain-patterns.ts | New module providing wildcard pattern detection, regex conversion, validation, and pattern matching utilities |
| src/domain-patterns.test.ts | Comprehensive test suite for the new domain pattern utilities covering edge cases and validation |
| src/squid-config.ts | Updated to parse domains into plain/pattern categories, generate separate ACL types, and combine them in http_access rules |
| src/squid-config.test.ts | Added test coverage for wildcard patterns, ACL generation, and mixed domain/pattern scenarios |
| src/cli.ts | Updated help text to document wildcard syntax and added validation for domain patterns before execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+33
to
+39
| // Skip if this is a wildcard pattern | ||
| if (isWildcardPattern(domain)) return true; | ||
|
|
||
| // Check if this domain is a subdomain of another plain domain in the list | ||
| return !arr.some((otherDomain, otherIndex) => { | ||
| if (index === otherIndex) return false; | ||
| if (isWildcardPattern(otherDomain)) return false; |
There was a problem hiding this comment.
The checks for isWildcardPattern(domain) and isWildcardPattern(otherDomain) are unnecessary here. At this point, plainDomains only contains plain domains (no wildcards) since they were already separated by parseDomainList(). These checks will always return false and can be removed.
Suggested change
| // Skip if this is a wildcard pattern | |
| if (isWildcardPattern(domain)) return true; | |
| // Check if this domain is a subdomain of another plain domain in the list | |
| return !arr.some((otherDomain, otherIndex) => { | |
| if (index === otherIndex) return false; | |
| if (isWildcardPattern(otherDomain)) return false; | |
| // Check if this domain is a subdomain of another plain domain in the list | |
| return !arr.some((otherDomain, otherIndex) => { | |
| if (index === otherIndex) return false; |
Contributor
Author
|
@copilot update documentation for this one and resolve comments |
Contributor
* Initial plan * fix: remove redundant wildcard checks and update docs Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiaxiao (mossaka) Zhou duibao55328@gmail.com