Remove timeout requirement for strict mode and set default timeout to 20 minutes - #1432
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove timeout requirement for strict mode and set default timeout to 20 minutes
Based on the problem statement, I have successfully completed:
docs/src/content/docs/reference/frontmatter.mdto remove timeout requirementdocs/src/content/docs/guides/security.mdto remove timeout requirementChanges Made:
Code Changes:
validateStrictTimeout()function call fromvalidateStrictMode()inpkg/workflow/strict_mode.govalidateStrictTimeout()function implementation (lines 36-82)pkg/workflow/strict_mode_test.go:TestStrictModeTimeout: Now tests that timeout is NOT required and is still valid when specifiedTestStrictModeFromFrontmatter: Updated to expect success without timeoutTestStrictModeIsolation: Updated to expect success for strict workflow without timeoutTestCLIStrictFlagTakesPrecedence: Updated to test write permission error instead of timeout errorDefault Timeout Changes (per user request):
DefaultAgenticWorkflowTimeoutMinutesconstant topkg/constants/constants.go(value: 20)pkg/workflow/tools.go: Changed to use constant instead of hardcoded valuepkg/workflow/claude_engine.go: Changed to use constant instead of hardcoded valuepkg/workflow/copilot_engine.go: Changed to use constant instead of hardcoded valueDocumentation Changes:
Updated
docs/src/content/docs/reference/frontmatter.md:timeout_minutes: 10from the example strict mode workflowUpdated
docs/src/content/docs/guides/security.md:timeout_minutes: 10from exampleWorkflow Files:
Testing & Validation:
Summary:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.